Improve naming of the isResilientConformance flag that disables optimizations

Thank you, Arnold, for talking through this with me.

Author: DougGregor

lib/IRGen/GenProto.cpp

@@ -960,11 +960,11 @@ namespace {
 /// Return true if the witness table requires runtime instantiation to
 /// handle resiliently-added requirements with default implementations.
 ///
-/// If ignoreGenericity is true, skip the optimization for non-generic
-/// conformances are considered non-resilient.
+/// If disableOptimizations is true, skip optimizations that treat
+/// formally-resilient conformances as non-resilient.
 bool IRGenModule::isResilientConformance(
     const NormalProtocolConformance *conformance,
-    bool ignoreGenericity
+    bool disableOptimizations
 ) {
   // If the protocol is not resilient, the conformance is not resilient
   // either.
@@ -998,17 +998,17 @@ bool IRGenModule::isResilientConformance(
   // resiliently become dependent.
   if (!conformance->getDeclContext()->isGenericContext() &&
       conformanceModule == conformance->getProtocol()->getParentModule() &&
-      !ignoreGenericity)
+      !disableOptimizations)
     return false;
 
   // We have a resilient conformance.
   return true;
 }
 
 bool IRGenModule::isResilientConformance(const RootProtocolConformance *root,
-                                         bool ignoreGenericity) {
+                                         bool disableOptimizations) {
   if (auto normal = dyn_cast<NormalProtocolConformance>(root))
-    return isResilientConformance(normal, ignoreGenericity);
+    return isResilientConformance(normal, disableOptimizations);
   // Self-conformances never require this.
   return false;
 }
@@ -1193,7 +1193,7 @@ bool IRGenModule::isDependentConformance(
   llvm::SmallPtrSet<const NormalProtocolConformance *, 4> visited;
   return ::isDependentConformance(
       *this, conformance,
-      isResilientConformance(conformance, /*ignoreGenericity=*/true),
+      isResilientConformance(conformance, /*disableOptimizations=*/true),
       visited);
 }
 

lib/IRGen/IRGenModule.h

@@ -1120,9 +1120,9 @@ class IRGenModule {
   TypeExpansionContext getMaximalTypeExpansionContext() const;
 
   bool isResilientConformance(const NormalProtocolConformance *conformance,
-                              bool ignoreGenericity = false);
+                              bool disableOptimizations = false);
   bool isResilientConformance(const RootProtocolConformance *root,
-                              bool ignoreGenericity = false);
+                              bool disableOptimizations = false);
   bool isDependentConformance(const RootProtocolConformance *conformance);
 
   Alignment getCappedAlignment(Alignment alignment);