NFC: Resolve "was never mutated" warnings in ASTGen.

tshortli · tshortli · commit 5ee9bfda7b10 · 2024-02-01T18:32:37.000-08:00
diff --git a/lib/ASTGen/Sources/ASTGen/Macros.swift b/lib/ASTGen/Sources/ASTGen/Macros.swift
@@ -393,7 +393,7 @@ func makeExpansionOutputResult(
   expandedSource: String?,
   outputPointer: UnsafeMutablePointer<BridgedStringRef>
 ) -> Int {
-  guard var expandedSource = expandedSource else {
+  guard let expandedSource = expandedSource else {
     outputPointer.pointee = BridgedStringRef()
     return -1
   }
diff --git a/lib/ASTGen/Sources/ASTGen/PluginHost.swift b/lib/ASTGen/Sources/ASTGen/PluginHost.swift
@@ -81,7 +81,7 @@ func swift_ASTGen_pluginServerLoadLibraryPlugin(
       assert(diagnostics.isEmpty)
       return true
     }
-    var errorMsgs = diagnostics.map({ $0.message }).joined(separator: ", ");
+    let errorMsgs = diagnostics.map({ $0.message }).joined(separator: ", ");
     errorOut?.pointee = allocateBridgedString(errorMsgs);
     return false
   } catch {

Original file line number	Diff line number	Diff line change
`@@ -393,7 +393,7 @@ func makeExpansionOutputResult(`
`393`	`393`	`expandedSource: String?,`
`394`	`394`	`outputPointer: UnsafeMutablePointer<BridgedStringRef>`
`395`	`395`	`) -> Int {`
`396`		`- guard var expandedSource = expandedSource else {`
	`396`	`+ guard let expandedSource = expandedSource else {`
`397`	`397`	`outputPointer.pointee = BridgedStringRef()`
`398`	`398`	`return -1`
`399`	`399`	`}`
Original file line number	Diff line number	Diff line change
`@@ -81,7 +81,7 @@ func swift_ASTGen_pluginServerLoadLibraryPlugin(`
`81`	`81`	`assert(diagnostics.isEmpty)`
`82`	`82`	`return true`
`83`	`83`	`}`
`84`		`- var errorMsgs = diagnostics.map({ $0.message }).joined(separator: ", ");`
	`84`	`+ let errorMsgs = diagnostics.map({ $0.message }).joined(separator: ", ");`
`85`	`85`	`errorOut?.pointee = allocateBridgedString(errorMsgs);`
`86`	`86`	`return false`
`87`	`87`	`} catch {`