[ast] Move ActorIsolation::dump out of line so we don't call print in a header.

This works around a layering violation where libSwiftBasic includes parts of the
AST even though it shouldn't.

Author: gottesmm

include/swift/AST/ActorIsolation.h

@@ -271,10 +271,7 @@ class ActorIsolation {
   void printForDiagnostics(llvm::raw_ostream &os,
                            StringRef openingQuotationMark = "'") const;
 
-  SWIFT_DEBUG_DUMP {
-    print(llvm::dbgs());
-    llvm::dbgs() << '\n';
-  }
+  SWIFT_DEBUG_DUMPER(dump());
 
   // Defined out of line to prevent linker errors since libswiftBasic would
   // include this header exascerbating a layering violation where libswiftBasic

lib/AST/TypeCheckRequests.cpp

@@ -1784,6 +1784,11 @@ void ActorIsolation::printForSIL(llvm::raw_ostream &os) const {
   llvm_unreachable("Covered switch isn't covered?!");
 }
 
+void ActorIsolation::dump() const {
+  print(llvm::dbgs());
+  llvm::dbgs() << '\n';
+}
+
 void ActorIsolation::dumpForDiagnostics() const {
   printForDiagnostics(llvm::dbgs());
   llvm::dbgs() << '\n';