Skip to content

Commit 5e1de49

Browse files
jPaolantonioJames Paolantonio
jPaolantonio
and
James Paolantonio
authored
[Const extract] Extract static function calls (#76251)
Co-authored-by: James Paolantonio <j_paolantonio@apple.com>
1 parent bd554ba commit 5e1de49

File tree

4 files changed

+164
-14
lines changed

4 files changed

+164
-14
lines changed

‎include/swift/AST/ConstTypeInfo.h‎

Lines changed: 25 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -40,6 +40,7 @@ class CompileTimeValue {
4040
Type,
4141
KeyPath,
4242
FunctionCall,
43+
StaticFunctionCall,
4344
MemberReference,
4445
InterpolatedString,
4546
Runtime
@@ -408,6 +409,30 @@ class FunctionCallValue : public CompileTimeValue {
408409
std::optional<std::vector<FunctionParameter>> Parameters;
409410
};
410411

412+
/// A static function reference representation such as
413+
/// let foo = MyStruct.bar(item: "")
414+
/// let foo = MyStruct.bar()
415+
class StaticFunctionCallValue : public CompileTimeValue {
416+
public:
417+
StaticFunctionCallValue(std::string Label, swift::Type Type,
418+
std::vector<FunctionParameter> Parameters)
419+
: CompileTimeValue(ValueKind::StaticFunctionCall), Label(Label),
420+
Type(Type), Parameters(Parameters) {}
421+
422+
static bool classof(const CompileTimeValue *T) {
423+
return T->getKind() == ValueKind::StaticFunctionCall;
424+
}
425+
426+
std::string getLabel() const { return Label; }
427+
swift::Type getType() const { return Type; }
428+
std::vector<FunctionParameter> getParameters() const { return Parameters; }
429+
430+
private:
431+
std::string Label;
432+
swift::Type Type;
433+
std::vector<FunctionParameter> Parameters;
434+
};
435+
411436
/// A member reference representation such as
412437
/// let foo = MyStruct.bar
413438
class MemberReferenceValue : public CompileTimeValue {

‎lib/ConstExtract/ConstExtract.cpp‎

Lines changed: 52 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -294,12 +294,12 @@ static std::shared_ptr<CompileTimeValue> extractCompileTimeValue(Expr *expr) {
294294

295295
if (functionKind == ExprKind::DeclRef) {
296296
auto declRefExpr = cast<DeclRefExpr>(callExpr->getFn());
297-
auto caseName =
297+
auto identifier =
298298
declRefExpr->getDecl()->getName().getBaseIdentifier().str().str();
299299

300300
std::vector<FunctionParameter> parameters =
301301
extractFunctionArguments(callExpr->getArgs());
302-
return std::make_shared<FunctionCallValue>(caseName, parameters);
302+
return std::make_shared<FunctionCallValue>(identifier, parameters);
303303
}
304304

305305
if (functionKind == ExprKind::ConstructorRefCall) {
@@ -313,12 +313,33 @@ static std::shared_ptr<CompileTimeValue> extractCompileTimeValue(Expr *expr) {
313313
auto fn = dotSyntaxCallExpr->getFn();
314314
if (fn->getKind() == ExprKind::DeclRef) {
315315
auto declRefExpr = cast<DeclRefExpr>(fn);
316-
auto caseName =
316+
auto baseIdentifierName =
317317
declRefExpr->getDecl()->getName().getBaseIdentifier().str().str();
318318

319319
std::vector<FunctionParameter> parameters =
320320
extractFunctionArguments(callExpr->getArgs());
321-
return std::make_shared<EnumValue>(caseName, parameters);
321+
322+
auto declRef = dotSyntaxCallExpr->getFn()->getReferencedDecl();
323+
switch (declRef.getDecl()->getKind()) {
324+
case DeclKind::EnumElement: {
325+
return std::make_shared<EnumValue>(baseIdentifierName, parameters);
326+
}
327+
328+
case DeclKind::Func: {
329+
auto identifier = declRefExpr->getDecl()
330+
->getName()
331+
.getBaseIdentifier()
332+
.str()
333+
.str();
334+
335+
return std::make_shared<StaticFunctionCallValue>(
336+
identifier, callExpr->getType(), parameters);
337+
}
338+
339+
default: {
340+
break;
341+
}
342+
}
322343
}
323344
}
324345

@@ -836,6 +857,27 @@ void writeValue(llvm::json::OStream &JSON,
836857
break;
837858
}
838859

860+
case CompileTimeValue::ValueKind::StaticFunctionCall: {
861+
auto staticFunctionCallValue = cast<StaticFunctionCallValue>(value);
862+
863+
JSON.attribute("valueKind", "StaticFunctionCall");
864+
JSON.attributeObject("value", [&]() {
865+
JSON.attribute("type", toFullyQualifiedTypeNameString(
866+
staticFunctionCallValue->getType()));
867+
JSON.attribute("memberLabel", staticFunctionCallValue->getLabel());
868+
JSON.attributeArray("arguments", [&] {
869+
for (auto FP : staticFunctionCallValue->getParameters()) {
870+
JSON.object([&] {
871+
JSON.attribute("label", FP.Label);
872+
JSON.attribute("type", toFullyQualifiedTypeNameString(FP.Type));
873+
writeValue(JSON, FP.Value);
874+
});
875+
}
876+
});
877+
});
878+
break;
879+
}
880+
839881
case CompileTimeValue::ValueKind::MemberReference: {
840882
auto memberReferenceValue = cast<MemberReferenceValue>(value);
841883
JSON.attribute("valueKind", "MemberReference");
@@ -846,6 +888,7 @@ void writeValue(llvm::json::OStream &JSON,
846888
});
847889
break;
848890
}
891+
849892
case CompileTimeValue::ValueKind::InterpolatedString: {
850893
auto interpolatedStringValue = cast<InterpolatedStringLiteralValue>(value);
851894
JSON.attribute("valueKind", "InterpolatedStringLiteral");
@@ -1062,14 +1105,11 @@ createBuilderCompileTimeValue(CustomAttr *AttachedResultBuilder,
10621105
void writeSingleBuilderMemberElement(
10631106
llvm::json::OStream &JSON, std::shared_ptr<CompileTimeValue> Element) {
10641107
switch (Element.get()->getKind()) {
1065-
case CompileTimeValue::ValueKind::Enum: {
1066-
auto enumValue = cast<EnumValue>(Element.get());
1067-
if (enumValue->getIdentifier() == "buildExpression") {
1068-
if (enumValue->getParameters().has_value()) {
1069-
auto params = enumValue->getParameters().value();
1070-
for (auto FP : params) {
1071-
writeValue(JSON, FP.Value);
1072-
}
1108+
case CompileTimeValue::ValueKind::StaticFunctionCall: {
1109+
auto staticFunctionCallValue = cast<StaticFunctionCallValue>(Element.get());
1110+
if (staticFunctionCallValue->getLabel() == "buildExpression") {
1111+
for (auto FP : staticFunctionCallValue->getParameters()) {
1112+
writeValue(JSON, FP.Value);
10731113
}
10741114
}
10751115
break;

‎test/ConstExtraction/ExtractCalls.swift‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -115,8 +115,8 @@ public struct Bat {
115115
// CHECK-NEXT: "name": "adder",
116116
// CHECK-NEXT: "arguments": [
117117
// CHECK-NEXT: {
118-
// CHECK-NEXT: "label": "",
119-
// CHECK-NEXT: "type": "Swift.Int",
118+
// CHECK-NEXT: "label": "",
119+
// CHECK-NEXT: "type": "Swift.Int",
120120
// CHECK-NEXT: "valueKind": "RawLiteral",
121121
// CHECK-NEXT: "value": "2"
122122
// CHECK-NEXT: },

‎test/ConstExtraction/ExtractStaticFunctions.swift‎

Lines changed: 85 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,85 @@
1+
// RUN: %empty-directory(%t)
2+
// RUN: echo "[MyProto]" > %t/protocols.json
3+
4+
// RUN: %target-swift-frontend -typecheck -emit-const-values-path %t/ExtractStaticFunctions.swiftconstvalues -const-gather-protocols-file %t/protocols.json -primary-file %s
5+
// RUN: cat %t/ExtractStaticFunctions.swiftconstvalues 2>&1 | %FileCheck %s
6+
7+
protocol MyProto {}
8+
9+
enum Bar {
10+
case one
11+
case two(item: String)
12+
}
13+
14+
struct Baz {
15+
static var one: Baz {
16+
Baz()
17+
}
18+
19+
static func two(item: String) -> Baz {
20+
return Baz()
21+
}
22+
23+
static func three() -> Baz {
24+
return Baz()
25+
}
26+
}
27+
28+
struct Statics: MyProto {
29+
var bar1 = Bar.one
30+
var bar2 = Bar.two(item: "bar")
31+
var baz1 = Baz.one
32+
var baz2 = Baz.two(item: "baz")
33+
var baz3 = Baz.three()
34+
}
35+
36+
// CHECK: "label": "bar1",
37+
// CHECK-NEXT: "type": "ExtractStaticFunctions.Bar",
38+
// CHECK: "valueKind": "Enum",
39+
// CHECK-NEXT: "value": {
40+
// CHECK-NEXT: "name": "one"
41+
// CHECK-NEXT: }
42+
// CHECK: "label": "bar2",
43+
// CHECK-NEXT: "type": "ExtractStaticFunctions.Bar",
44+
// CHECK: "valueKind": "Enum",
45+
// CHECK-NEXT: "value": {
46+
// CHECK-NEXT: "name": "two",
47+
// CHECK-NEXT: "arguments": [
48+
// CHECK-NEXT: {
49+
// CHECK-NEXT: "label": "item",
50+
// CHECK-NEXT: "type": "Swift.String",
51+
// CHECK-NEXT: "valueKind": "RawLiteral",
52+
// CHECK-NEXT: "value": "bar"
53+
// CHECK-NEXT: }
54+
// CHECK-NEXT: ]
55+
// CHECK-NEXT: }
56+
// CHECK: "label": "baz1",
57+
// CHECK-NEXT: "type": "ExtractStaticFunctions.Baz",
58+
// CHECK: "valueKind": "MemberReference"
59+
// CHECK-NEXT: "value": {
60+
// CHECK-NEXT: "baseType": "ExtractStaticFunctions.Baz",
61+
// CHECK-NEXT: "memberLabel": "one"
62+
// CHECK-NEXT: }
63+
// CHECK: "label": "baz2",
64+
// CHECK-NEXT: "type": "ExtractStaticFunctions.Baz",
65+
// CHECK: "valueKind": "StaticFunctionCall",
66+
// CHECK-NEXT: "value": {
67+
// CHECK-NEXT: "type": "ExtractStaticFunctions.Baz",
68+
// CHECK-NEXT: "memberLabel": "two",
69+
// CHECK-NEXT: "arguments": [
70+
// CHECK-NEXT: {
71+
// CHECK-NEXT: "label": "item",
72+
// CHECK-NEXT: "type": "Swift.String",
73+
// CHECK-NEXT: "valueKind": "RawLiteral",
74+
// CHECK-NEXT: "value": "baz"
75+
// CHECK-NEXT: }
76+
// CHECK-NEXT: ]
77+
// CHECK-NEXT: }
78+
// CHECK: "label": "baz3",
79+
// CHECK-NEXT: "type": "ExtractStaticFunctions.Baz",
80+
// CHECK: "valueKind": "StaticFunctionCall",
81+
// CHECK-NEXT: "value": {
82+
// CHECK-NEXT: "type": "ExtractStaticFunctions.Baz",
83+
// CHECK-NEXT: "memberLabel": "three",
84+
// CHECK-NEXT: "arguments": []
85+
// CHECK-NEXT: }

0 commit comments

Comments
 (0)