Merge pull request #37241 from ahoppen/pr/invalid-deferred-length

[libSyntax] Explicitly return 0 as length of missing deferred tokens

Author: ahoppen

test/Syntax/Parser/fixed_crashers.swift

@@ -6,3 +6,6 @@ let x: a[i] & b
 
 let x2: a & b[1]
 // CHECK: |x2|
+
+let x3: (A -> B)
+// CHECK: |x3|

tools/libSwiftSyntaxParser/libSwiftSyntaxParser.cpp

@@ -111,6 +111,16 @@ struct DeferredTokenNode {
       : IsMissing(IsMissing), TokenKind(TokenKind),
         LeadingTrivia(LeadingTrivia), TrailingTrivia(TrailingTrivia),
         Range(Range) {}
+
+  /// Returns the length of this token or \c 0 if the token is missing.
+  size_t getLength() const {
+    if (IsMissing) {
+      return 0;
+    } else {
+      assert(Range.isValid());
+      return Range.getByteLength();
+    }
+  }
 };
 
 struct DeferredLayoutNode {
@@ -272,7 +282,7 @@ class CLibParseActions final : public SyntaxParseActions {
         break;
       case RecordedOrDeferredNode::Kind::DeferredToken:
         length += static_cast<const DeferredTokenNode *>(child.getOpaque())
-                      ->Range.getByteLength();
+                      ->getLength();
         break;
       }
     }
@@ -373,7 +383,7 @@ class CLibParseActions final : public SyntaxParseActions {
       case RecordedOrDeferredNode::Kind::DeferredToken:
         StartLoc = StartLoc.getAdvancedLoc(
             static_cast<const DeferredTokenNode *>(Child.getOpaque())
-                ->Range.getByteLength());
+                ->getLength());
         break;
       }
     }