[no-implicit-copy] Remove the move only bit in type lowering for now.

We currently do not need it so I am removing it. We /do/ use move only as a
TypeLowering itself though. Just not as a property.

Author: gottesmm

include/swift/SIL/TypeLowering.h

@@ -169,12 +169,6 @@ enum IsInfiniteType_t : bool {
   IsInfiniteType = true,
 };
 
-/// Does this type contain a move only type that affects type lowering?
-enum IsMoveOnly_t : bool {
-  IsNotMoveOnly = false,
-  IsMoveOnly = true,
-};
-
 /// Extended type information used by SIL.
 class TypeLowering {
 public:
@@ -190,7 +184,6 @@ class TypeLowering {
       TypeExpansionSensitiveFlag = 1 << 4,
       InfiniteFlag               = 1 << 5,
       HasRawPointerFlag          = 1 << 6,
-      MoveOnlyFlag               = 1 << 7,
     };
     // clang-format on
 
@@ -205,15 +198,13 @@ class TypeLowering {
         IsAddressOnly_t isAddressOnly, IsResilient_t isResilient,
         IsTypeExpansionSensitive_t isTypeExpansionSensitive =
             IsNotTypeExpansionSensitive,
-        HasRawPointer_t hasRawPointer = DoesNotHaveRawPointer,
-        IsMoveOnly_t isMoveOnly = IsNotMoveOnly)
+        HasRawPointer_t hasRawPointer = DoesNotHaveRawPointer)
         : Flags((isTrivial ? 0U : NonTrivialFlag) |
                 (isFixedABI ? 0U : NonFixedABIFlag) |
                 (isAddressOnly ? AddressOnlyFlag : 0U) |
                 (isResilient ? ResilientFlag : 0U) |
                 (isTypeExpansionSensitive ? TypeExpansionSensitiveFlag : 0U) |
-                (hasRawPointer ? HasRawPointerFlag : 0U) |
-                (isMoveOnly ? MoveOnlyFlag : 0U)) {}
+                (hasRawPointer ? HasRawPointerFlag : 0U)) {}
 
     constexpr bool operator==(RecursiveProperties p) const {
       return Flags == p.Flags;
@@ -240,36 +231,6 @@ class TypeLowering {
       return {IsTrivial, IsFixedABI, IsNotAddressOnly, IsResilient};
     }
 
-    static constexpr RecursiveProperties forMoveOnlyReference() {
-      return {IsNotTrivial,
-              IsFixedABI,
-              IsNotAddressOnly,
-              IsNotResilient,
-              IsNotTypeExpansionSensitive,
-              DoesNotHaveRawPointer,
-              IsMoveOnly};
-    }
-
-    static constexpr RecursiveProperties forMoveOnlyOpaque() {
-      return {IsNotTrivial,
-              IsNotFixedABI,
-              IsAddressOnly,
-              IsNotResilient,
-              IsNotTypeExpansionSensitive,
-              DoesNotHaveRawPointer,
-              IsMoveOnly};
-    }
-
-    static constexpr RecursiveProperties forMoveOnlyResilient() {
-      return {IsTrivial,
-              IsFixedABI,
-              IsNotAddressOnly,
-              IsResilient,
-              IsNotTypeExpansionSensitive,
-              DoesNotHaveRawPointer,
-              IsMoveOnly};
-    }
-
     void addSubobject(RecursiveProperties other) {
       Flags |= other.Flags;
     }
@@ -296,9 +257,6 @@ class TypeLowering {
     IsInfiniteType_t isInfinite() const {
       return IsInfiniteType_t((Flags & InfiniteFlag) != 0);
     }
-    IsMoveOnly_t isMoveOnlyWrapped() const {
-      return IsMoveOnly_t((Flags & MoveOnlyFlag) != 0);
-    }
 
     void setNonTrivial() { Flags |= NonTrivialFlag; }
     void setNonFixedABI() { Flags |= NonFixedABIFlag; }
@@ -309,7 +267,6 @@ class TypeLowering {
               (isTypeExpansionSensitive ? TypeExpansionSensitiveFlag : 0);
     }
     void setInfinite() { Flags |= InfiniteFlag; }
-    void setMoveOnly() { Flags |= MoveOnlyFlag; }
   };
 
 private:

lib/SIL/IR/TypeLowering.cpp

@@ -244,24 +244,12 @@ namespace {
                                            RecursiveProperties::forReference());
     }
 
-    RecursiveProperties getMoveOnlyReferenceRecursiveProperties(
-        IsTypeExpansionSensitive_t isSensitive) {
-      return mergeIsTypeExpansionSensitive(isSensitive,
-                                           RecursiveProperties::forReference());
-    }
-
     RecursiveProperties
     getOpaqueRecursiveProperties(IsTypeExpansionSensitive_t isSensitive) {
       return mergeIsTypeExpansionSensitive(isSensitive,
                                            RecursiveProperties::forOpaque());
     }
 
-    RecursiveProperties getMoveOnlyOpaqueRecursiveProperties(
-        IsTypeExpansionSensitive_t isSensitive) {
-      return mergeIsTypeExpansionSensitive(
-          isSensitive, RecursiveProperties::forMoveOnlyOpaque());
-    }
-
 #define IMPL(TYPE, LOWERING)                                                 \
     RetTy visit##TYPE##Type(Can##TYPE##Type type, AbstractionPattern orig,   \
                             IsTypeExpansionSensitive_t isSensitive) {        \
@@ -704,12 +692,12 @@ namespace {
       if (lowering.isAddressOnly()) {
         return asImpl().handleMoveOnlyAddressOnly(
             type->getCanonicalType(),
-            getMoveOnlyOpaqueRecursiveProperties(isSensitive));
+            getOpaqueRecursiveProperties(isSensitive));
       }
 
       return asImpl().handleMoveOnlyReference(
           type->getCanonicalType(),
-          getMoveOnlyReferenceRecursiveProperties(isSensitive));
+          getReferenceRecursiveProperties(isSensitive));
     }
 
     RetTy handleAggregateByProperties(CanType type, RecursiveProperties props) {