Merge pull request #36367 from apple/QuietMisdreavus/symbol-availability

[SymbolGraph] don't filter out symbols if their availability was for a platform-agnostic target

rdar://74670284

Author: QuietMisdreavus

lib/SymbolGraphGen/SymbolGraphASTWalker.cpp

@@ -64,12 +64,14 @@ namespace {
 bool isUnavailableOrObsoleted(const Decl *D) {
   if (const auto *Avail =
         D->getAttrs().getUnavailable(D->getASTContext())) {
-    switch (Avail->getVersionAvailability(D->getASTContext())) {
-      case AvailableVersionComparison::Unavailable:
-      case AvailableVersionComparison::Obsoleted:
-        return true;
-      default:
-        break;
+    if (Avail->Platform != PlatformKind::none) {
+      switch (Avail->getVersionAvailability(D->getASTContext())) {
+        case AvailableVersionComparison::Unavailable:
+        case AvailableVersionComparison::Obsoleted:
+          return true;
+        default:
+          break;
+      }
     }
   }
   return false;

test/SymbolGraph/Symbols/Mixins/Availability/PlatformAgnostic.swift

@@ -0,0 +1,19 @@
+// RUN: %empty-directory(%t)
+// RUN: %target-build-swift %s -module-name PlatformAgnostic -emit-module -emit-module-path %t/
+// RUN: %target-swift-symbolgraph-extract -module-name PlatformAgnostic -I %t -pretty-print -output-dir %t
+
+// RUN: %FileCheck %s --input-file %t/PlatformAgnostic.symbols.json --check-prefix CHECK-FS
+// RUN: %FileCheck %s --input-file %t/PlatformAgnostic.symbols.json --check-prefix CHECK-FP
+// RUN: %FileCheck %s --input-file %t/PlatformAgnostic.symbols.json --check-prefix CHECK-SO
+
+// CHECK-FS: FutureSwift
+@available(swift 99)
+public struct FutureSwift {}
+
+// CHECK-FP: FuturePackage
+@available(_PackageDescription 99)
+public struct FuturePackage {}
+
+// CHECK-SO: SwiftObsolete
+@available(swift, obsoleted: 1.0)
+public struct SwiftObsolete {}

test/SymbolGraph/Symbols/Unavailable.swift

@@ -25,13 +25,4 @@ extension ShouldAppear {
   public func shouldntAppear2() {}
 }
 
-// CHECK-NOT: SwiftObsoleted
-@available(swift, obsoleted: 1.0)
-public struct SwiftObsoleted {}
-
-@available(swift, obsoleted: 1.0)
-extension ShouldAppear {
-  public func shouldntAppear3() {}
-}
-
 // CHECK-NOT: shouldntAppear