Merge pull request #76377 from xedin/dont-discriminate-against-any-and-anyobject

[CSSimplify] Don't increase impact if member doesn't exist on Any/Any…

Author: xedin

lib/Sema/CSSimplify.cpp

@@ -11024,9 +11024,6 @@ ConstraintSystem::SolutionKind ConstraintSystem::simplifyMemberConstraint(
         impact += 10;
       }
 
-      if (instanceTy->isAny() || instanceTy->isAnyObject())
-        impact += 5;
-
       auto *anchorExpr = getAsExpr(locator->getAnchor());
       if (anchorExpr) {
         if (auto *UDE = dyn_cast<UnresolvedDotExpr>(anchorExpr)) {

test/Constraints/members.swift

@@ -826,3 +826,14 @@ do {
     // expected-error@-1 {{value of type 'any BinaryInteger' has no member 'op'}}
   }
 }
+
+do {
+  func test<T>(_: T) -> T? { nil }
+  func test<U>(_: U) -> Int { 0 }
+
+  func compute(x: Any) {
+    test(x)!.unknown()
+    // expected-error@-1 {{value of type 'Any' has no member 'unknown'}}
+    // expected-note@-2 {{cast 'Any' to 'AnyObject' or use 'as!' to force downcast to a more specific type to access members}}
+  }
+}