Merge pull request #59263 from rintaro/ide-completion-precedencegroup-rdar76977760

[CodeCompletion] Don't suggest precedence groups in expr/type position

Author: rintaro

lib/IDE/CodeCompletionConsumer.cpp

@@ -71,7 +71,9 @@ static MutableArrayRef<CodeCompletionResult *> copyCodeCompletionResults(
     };
   } else {
     shouldIncludeResult = [](const ContextFreeCodeCompletionResult *R) -> bool {
-      return true;
+      // PrecedenceGroups are only valid in 'onlyPrecedenceGroups'.
+      return R->getAssociatedDeclKind() !=
+             CodeCompletionDeclKind::PrecedenceGroup;
     };
   }
 

test/IDE/complete_precedencegroup.swift

@@ -19,6 +19,9 @@
 // RUN: %target-swift-ide-test -code-completion -source-filename %s -code-completion-token=ASSIGNMENT_1 | %FileCheck %s -check-prefix=ASSIGNMENT
 // RUN: %target-swift-ide-test -code-completion -source-filename %s -code-completion-token=ASSIGNMENT_2 | %FileCheck %s -check-prefix=ASSIGNMENT
 
+// RUN: %target-swift-ide-test -code-completion -source-filename %s -code-completion-token=GLOBAL_EXPR | %FileCheck %s -check-prefix=PRECEDENCE_GROUP_NEGATIVE
+// RUN: %target-swift-ide-test -code-completion -source-filename %s -code-completion-token=GLOBAL_TYPE | %FileCheck %s -check-prefix=PRECEDENCE_GROUP_NEGATIVE
+
 infix operator +++: #^PRECEDENCE_GROUP_1^#
 
 precedencegroup MyPrecedence1 {
@@ -82,6 +85,13 @@ precedencegroup MyPrecedence12 {
 
 infix operator ---: #^PRECEDENCE_GROUP_CURRFILE^#
 
+func testExpr() {
+  _ = #^GLOBAL_EXPR^#
+}
+func testType() {
+  let _: #^GLOBAL_TYPE^#
+}
+
 // ATTRIBUTE_LIST: Begin completions, 4 items
 // ATTRIBUTE_LIST: Keyword/None: associativity; name=associativity
 // ATTRIBUTE_LIST: Keyword/None: higherThan;    name=higherThan
@@ -117,3 +127,7 @@ infix operator ---: #^PRECEDENCE_GROUP_CURRFILE^#
 // PRECEDENCE_GROUP_CURRFILE-DAG: Decl[PrecedenceGroup]/CurrModule: MyPrecedence{{[0-9]+}};
 
 // PRECEDENCE_GROUP_MULTIFILE: Decl[PrecedenceGroup]/CurrModule: PrecedenceGroupOtherFile; name=PrecedenceGroupOtherFile
+
+// PRECEDENCE_GROUP_NEGATIVE: Begin completions
+// PRECEDENCE_GROUP_NEGATIVE-NOT: Decl[PrecedenceGroup]
+// PRECEDENCE_GROUP_NEGATIVE: End completions