Rename -> isInterfacePackageEffectivelyPublic

Author: elsh

include/swift/AST/Decl.h

@@ -2979,7 +2979,7 @@ class ValueDecl : public Decl {
   /// - Has a @usableFromInline (or other inlinable) attribute,
   /// - And is defined in a module built from a public or private
   ///   interface that does not contain package-name.
-  bool isPackageEffectivelyPublic() const;
+  bool isInterfacePackageEffectivelyPublic() const;
 
   /// Returns \c true if this declaration is *not* intended to be used directly
   /// by application developers despite the visibility.

lib/AST/ASTVerifier.cpp

@@ -1016,7 +1016,7 @@ class Verifier : public ASTWalker {
         if (!D->getASTContext().isAccessControlDisabled()) {
           if (D->getFormalAccessScope().isPublic() &&
               D->getFormalAccess() < AccessLevel::Public &&
-              !D->isPackageEffectivelyPublic()) {
+              !D->isInterfacePackageEffectivelyPublic()) {
             Out << "non-public decl has no formal access scope\n";
             D->dump(Out);
             abort();

lib/AST/Decl.cpp

@@ -4212,7 +4212,7 @@ bool ValueDecl::isUsableFromInline() const {
   return false;
 }
 
-bool ValueDecl::isPackageEffectivelyPublic() const {
+bool ValueDecl::isInterfacePackageEffectivelyPublic() const {
   // If a package decl has a @usableFromInline (or other inlinable)
   // attribute, and is defined in a module built from interface, it
   // can be referenced by another module that imports it even though
@@ -4319,7 +4319,7 @@ static AccessLevel getAdjustedFormalAccess(const ValueDecl *VD,
   if (useDC && VD->getASTContext().isAccessControlDisabled())
     return getMaximallyOpenAccessFor(VD);
 
-  if (VD->isPackageEffectivelyPublic())
+  if (VD->isInterfacePackageEffectivelyPublic())
     return AccessLevel::Public;
 
   if (treatUsableFromInlineAsPublic &&
@@ -4504,7 +4504,7 @@ getAccessScopeForFormalAccess(const ValueDecl *VD,
   case AccessLevel::Package: {
     auto pkg = resultDC->getPackageContext(/*lookupIfNotCurrent*/ true);
     if (!pkg) {
-      if (VD->isPackageEffectivelyPublic())
+      if (VD->isInterfacePackageEffectivelyPublic())
         return AccessScope::getPublic();
       // Instead of reporting and failing early, return the scope of resultDC to
       // allow continuation (should still non-zero exit later if in script mode)
@@ -4641,7 +4641,7 @@ static bool checkAccess(const DeclContext *useDC, const ValueDecl *VD,
   if (VD->getASTContext().isAccessControlDisabled())
     return true;
 
-  if (VD->isPackageEffectivelyPublic())
+  if (VD->isInterfacePackageEffectivelyPublic())
     return true;
 
   auto access = getAccessLevel();

lib/Sema/TypeCheckProtocol.cpp

@@ -4277,7 +4277,7 @@ ConformanceChecker::resolveWitnessViaLookup(ValueDecl *requirement) {
           requiredAccessScope.requiredAccessForDiagnostics();
         auto proto = conformance->getProtocol();
         auto protoAccessScope = proto->getFormalAccessScope(DC);
-        if (proto->isPackageEffectivelyPublic())
+        if (proto->isInterfacePackageEffectivelyPublic())
           return;
 
         bool protoForcesAccess =