Skip to content

Commit 4de7e8c

Browse files
Merge pull request #85075 from charles-zablit/charles-zablit/windows/lldb-only-run-swift-test-subset
[windows] only test the Swift subset of LLDB tests in CI
2 parents a8c6c96 + 3df36f4 commit 4de7e8c

File tree

2 files changed

+11
-10
lines changed

2 files changed

+11
-10
lines changed

utils/build-windows-toolchain.bat

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -62,7 +62,7 @@ set TMPDIR=%BuildRoot%\tmp
6262
set NINJA_STATUS=[%%f/%%t][%%p][%%es]
6363

6464
:: Build the -Test argument, if any, by subtracting skipped tests
65-
set TestArg=-Test lld,lldb,swift,dispatch,foundation,xctest,swift-format,sourcekit-lsp,
65+
set TestArg=-Test lld,lldb,lldb-swift,swift,dispatch,foundation,xctest,swift-format,sourcekit-lsp,
6666
for %%I in (%SKIP_TESTS%) do (call set TestArg=%%TestArg:%%I,=%%)
6767
if "%TestArg:~-1%"=="," (set TestArg=%TestArg:~0,-1%) else (set TestArg= )
6868

utils/build.ps1

Lines changed: 10 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -120,7 +120,7 @@ Skip building the MSI installers and packaging. Useful for development builds.
120120
121121
.PARAMETER Test
122122
An array of names of projects to run tests for. Use '*' to run all tests.
123-
Available tests: lld, lldb, swift, dispatch, foundation, xctest, swift-format, sourcekit-lsp
123+
Available tests: lld, lldb, lldb-swift, swift, dispatch, foundation, xctest, swift-format, sourcekit-lsp
124124
125125
.PARAMETER IncludeDS2
126126
Include the ds2 remote debug server in the SDK.
@@ -262,7 +262,7 @@ if ($Test.Length -eq 1) { $Test = $Test[0].Split(",") }
262262

263263
if ($Test -contains "*") {
264264
# Explicitly don't include llbuild yet since tests are known to fail on Windows
265-
$Test = @("lld", "lldb", "swift", "dispatch", "foundation", "xctest", "swift-format", "sourcekit-lsp")
265+
$Test = @("lld", "lldb", "lldb-swift", "swift", "dispatch", "foundation", "xctest", "swift-format", "sourcekit-lsp")
266266
}
267267

268268
if ($UseHostToolchain -is [string]) {
@@ -1320,7 +1320,7 @@ function Get-Dependencies {
13201320
Install-PIPIfNeeded
13211321
Install-PythonModule "packaging" # For building LLVM 18+
13221322
Install-PythonModule "setuptools" # Required for SWIG support
1323-
if ($Test -contains "lldb") {
1323+
if ($Test -contains "lldb" -or $Test -contains "lldb-swift") {
13241324
Install-PythonModule "psutil" # Required for testing LLDB
13251325
}
13261326
}
@@ -1354,7 +1354,7 @@ function Get-Dependencies {
13541354

13551355
DownloadAndVerify $PinnedBuild "$BinaryCache\$PinnedToolchain.exe" $PinnedSHA256
13561356

1357-
if ($Test -contains "lldb") {
1357+
if ($Test -contains "lldb" -or $Test -contains "lldb-swift") {
13581358
# The make tool isn't part of MSYS
13591359
$GnuWin32MakeURL = "https://downloads.sourceforge.net/project/ezwinports/make-4.4.1-without-guile-w32-bin.zip"
13601360
$GnuWin32MakeHash = "fb66a02b530f7466f6222ce53c0b602c5288e601547a034e4156a512dd895ee7"
@@ -2310,17 +2310,17 @@ function Build-Compilers([Hashtable] $Platform, [string] $Variant) {
23102310
Write-PList -Settings $Settings -Path "$($Platform.ToolchainInstallRoot)\ToolchainInfo.plist"
23112311
}
23122312

2313-
function Test-Compilers([Hashtable] $Platform, [string] $Variant, [switch] $TestClang, [switch] $TestLLD, [switch] $TestLLDB, [switch] $TestLLVM, [switch] $TestSwift) {
2313+
function Test-Compilers([Hashtable] $Platform, [string] $Variant, [switch] $TestClang, [switch] $TestLLD, [switch] $TestLLDB, [switch] $TestLLDBSwift, [switch] $TestLLVM, [switch] $TestSwift) {
23142314
Invoke-IsolatingEnvVars {
23152315
$env:Path = "$(Get-CMarkBinaryCache $Platform)\src;$(Get-ProjectBinaryCache $BuildPlatform Compilers)\tools\swift\libdispatch-windows-$($Platform.Architecture.LLVMName)-prefix\bin;$(Get-ProjectBinaryCache $BuildPlatform Compilers)\bin;$env:Path;$VSInstallRoot\DIA SDK\bin\$($HostPlatform.Architecture.VSName);$UnixToolsBinDir"
23162316
$TestingDefines = Get-CompilersDefines $Platform $Variant -Test
23172317
if ($TestLLVM) { $Targets += @("check-llvm") }
23182318
if ($TestClang) { $Targets += @("check-clang") }
23192319
if ($TestLLD) { $Targets += @("check-lld") }
23202320
if ($TestSwift) { $Targets += @("check-swift", "SwiftCompilerPlugin") }
2321-
if ($TestLLDB) {
2322-
$Targets += @("check-lldb")
2323-
2321+
if ($TestLLDB) { $Targets += @("check-lldb") }
2322+
if ($TestLLDBSwift) { $Targets += @("check-lldb-swift") }
2323+
if ($TestLLDB -or $TestLLDBSwift) {
23242324
# Override test filter for known issues in downstream LLDB
23252325
Load-LitTestOverrides ([IO.Path]::GetFullPath([IO.Path]::Combine($PSScriptRoot, "..", "..", "llvm-project", "lldb", "test", "windows-swift-llvm-lit-test-overrides.txt")))
23262326

@@ -4446,12 +4446,13 @@ if ($Stage) {
44464446
}
44474447

44484448
if (-not $IsCrossCompiling) {
4449-
$CompilersTests = @("clang", "lld", "lldb", "llvm", "swift")
4449+
$CompilersTests = @("clang", "lld", "lldb", "lldb-swift", "llvm", "swift")
44504450
if ($Test | Where-Object { $CompilersTests -contains $_ }) {
44514451
$Tests = @{
44524452
"-TestClang" = $Test -contains "clang";
44534453
"-TestLLD" = $Test -contains "lld";
44544454
"-TestLLDB" = $Test -contains "lldb";
4455+
"-TestLLDBSwift" = $Test -contains "lldb-swift";
44554456
"-TestLLVM" = $Test -contains "llvm";
44564457
"-TestSwift" = $Test -contains "swift";
44574458
}

0 commit comments

Comments
 (0)