Merge pull request #39901 from al45tair/problem/84571859-2

[Stdlib] Enable -Wformat-nonliteral and make it an error.

Author: al45tair

stdlib/public/CMakeLists.txt

@@ -38,6 +38,14 @@ elseif(CMAKE_SYSTEM_NAME STREQUAL "OpenBSD")
   list(APPEND SWIFT_RUNTIME_CORE_CXX_FLAGS "-xc++")
 endif()
 
+# We should avoid non-literals in format strings, or appropriately mark
+# functions.
+check_cxx_compiler_flag("-Wformat-nonliteral -Werror=format-nonliteral" CXX_SUPPORTS_FORMAT_NONLITERAL_WARNING)
+if (CXX_SUPPORTS_FORMAT_NONLITERAL_WARNING)
+  list(APPEND SWIFT_RUNTIME_CORE_CXX_FLAGS "-Wformat-nonliteral"
+    "-Werror=format-nonliteral")
+endif()
+
 # C++ code in the runtime and standard library should generally avoid
 # introducing static constructors or destructors.
 check_cxx_compiler_flag("-Wglobal-constructors -Werror=global-constructors" CXX_SUPPORTS_GLOBAL_CONSTRUCTORS_WARNING)