Merge pull request #70301 from eeckstein/fixed-array

Add experimental support for fixed arrays

Author: eeckstein

SwiftCompilerSources/Sources/Optimizer/FunctionPasses/AllocVectorLowering.swift

@@ -7,6 +7,7 @@
 # See http://swift.org/CONTRIBUTORS.txt for Swift project authors
 
 swift_compiler_sources(Optimizer
+  AllocVectorLowering.swift
   AssumeSingleThreaded.swift
   AsyncDemotion.swift
   CleanupDebugSteps.swift

SwiftCompilerSources/Sources/Optimizer/FunctionPasses/CMakeLists.txt

@@ -394,27 +394,6 @@ private extension InstructionWorklist {
   }
 }
 
-private extension Value {
-  /// Returns true if this value is a valid in a static initializer, including all its operands.
-  var isValidGlobalInitValue: Bool {
-    guard let svi = self as? SingleValueInstruction else {
-      return false
-    }
-    if let beginAccess = svi as? BeginAccessInst {
-      return beginAccess.address.isValidGlobalInitValue
-    }
-    if !svi.isValidInStaticInitializerOfGlobal {
-      return false
-    }
-    for op in svi.operands {
-      if !op.value.isValidGlobalInitValue {
-        return false
-      }
-    }
-    return true
-  }
-}
-
 private extension AllocRefInstBase {
   var fieldsKnownStatically: Bool {
     if let allocDynamic = self as? AllocRefDynamicInst,

SwiftCompilerSources/Sources/Optimizer/FunctionPasses/ObjectOutliner.swift

@@ -37,7 +37,7 @@ protocol LateOnoneSimplifyable : Instruction {
 let ononeSimplificationPass = FunctionPass(name: "onone-simplification") {
   (function: Function, context: FunctionPassContext) in
 
-  _ = runSimplification(on: function, context, preserveDebugInfo: true) {
+  runSimplification(on: function, context, preserveDebugInfo: true) {
     if let i = $0 as? OnoneSimplifyable {
       i.simplify($1)
     }
@@ -47,7 +47,7 @@ let ononeSimplificationPass = FunctionPass(name: "onone-simplification") {
 let simplificationPass = FunctionPass(name: "simplification") {
   (function: Function, context: FunctionPassContext) in
 
-  _ = runSimplification(on: function, context, preserveDebugInfo: false) {
+  runSimplification(on: function, context, preserveDebugInfo: false) {
     if let i = $0 as? Simplifyable {
       i.simplify($1)
     }
@@ -57,7 +57,7 @@ let simplificationPass = FunctionPass(name: "simplification") {
 let lateOnoneSimplificationPass = FunctionPass(name: "late-onone-simplification") {
   (function: Function, context: FunctionPassContext) in
 
-  _ = runSimplification(on: function, context, preserveDebugInfo: true) {
+  runSimplification(on: function, context, preserveDebugInfo: true) {
     if let i = $0 as? LateOnoneSimplifyable {
       i.simplifyLate($1)
     } else if let i = $0 as? OnoneSimplifyable {
@@ -70,7 +70,7 @@ let lateOnoneSimplificationPass = FunctionPass(name: "late-onone-simplification"
 //                         Pass implementation
 //===--------------------------------------------------------------------===//
 
-
+@discardableResult
 func runSimplification(on function: Function, _ context: FunctionPassContext,
                        preserveDebugInfo: Bool,
                        _ simplify: (Instruction, SimplifyContext) -> ()) -> Bool {

SwiftCompilerSources/Sources/Optimizer/FunctionPasses/SimplificationPasses.swift

@@ -41,6 +41,7 @@ extension BuiltinInst : OnoneSimplifyable {
            .AssignCopyArrayFrontToBack,
            .AssignCopyArrayBackToFront,
            .AssignTakeArray,
+           .AllocVector,
            .IsPOD:
         optimizeArgumentToThinMetatype(argument: 0, context)
       case .CreateAsyncTask:

SwiftCompilerSources/Sources/Optimizer/InstructionSimplification/SimplifyBuiltin.swift

@@ -43,9 +43,13 @@ extension Context {
     }
   }
 
+  var moduleIsSerialized: Bool { _bridged.moduleIsSerialized() }
+
   func lookupDeinit(ofNominal: NominalTypeDecl) -> Function? {
     _bridged.lookUpNominalDeinitFunction(ofNominal.bridged).function
   }
+
+  func getBuiltinIntegerType(bitWidth: Int) -> Type { _bridged.getBuiltinIntegerType(bitWidth).type }
 }
 
 /// A context which allows mutation of a function's SIL.
@@ -494,6 +498,11 @@ extension Instruction {
     bridged.setOperand(index, value.bridged)
     context.notifyInstructionChanged(self)
   }
+
+  func move(before otherInstruction: Instruction, _ context: some MutatingContext) {
+    BridgedPassContext.moveInstructionBefore(bridged, otherInstruction.bridged)
+    context.notifyInstructionsChanged()
+  }
 }
 
 extension BuiltinInst {

SwiftCompilerSources/Sources/Optimizer/PassManager/Context.swift

@@ -29,7 +29,11 @@ struct Options {
   }
 
   var enableEmbeddedSwift: Bool {
-    _bridged.enableEmbeddedSwift()
+    _bridged.hasFeature(.Embedded)
+  }
+
+  func hasFeature(_ feature: BridgedPassContext.Feature) -> Bool {
+    _bridged.hasFeature(feature)
   }
 
   enum AssertConfiguration {

SwiftCompilerSources/Sources/Optimizer/PassManager/Options.swift

@@ -65,6 +65,7 @@ private func registerSwiftPasses() {
   registerPass(stackProtection, { stackProtection.run($0) })
 
   // Function passes
+  registerPass(allocVectorLowering, { allocVectorLowering.run($0) })
   registerPass(asyncDemotion, { asyncDemotion.run($0) })
   registerPass(letPropertyLowering, { letPropertyLowering.run($0) })
   registerPass(mergeCondFailsPass, { mergeCondFailsPass.run($0) })

SwiftCompilerSources/Sources/Optimizer/PassManager/PassRegistration.swift

@@ -131,6 +131,37 @@ extension Value {
     }
     return builder.createCopyValue(operand: self)
   }
+
+  /// True if this value is a valid in a static initializer, including all its operands.
+  var isValidGlobalInitValue: Bool {
+    guard let svi = self as? SingleValueInstruction else {
+      return false
+    }
+    if let beginAccess = svi as? BeginAccessInst {
+      return beginAccess.address.isValidGlobalInitValue
+    }
+    if !svi.isValidInStaticInitializerOfGlobal {
+      return false
+    }
+    for op in svi.operands {
+      if !op.value.isValidGlobalInitValue {
+        return false
+      }
+    }
+    return true
+  }
+}
+
+extension FullApplySite {
+  func isSemanticCall(_ name: StaticString, withArgumentCount: Int) -> Bool {
+    if arguments.count == withArgumentCount,
+       let callee = referencedFunction,
+       callee.hasSemanticsAttribute(name)
+    {
+      return true
+    }
+    return false
+  }
 }
 
 extension Builder {

SwiftCompilerSources/Sources/Optimizer/Utilities/OptUtils.swift

@@ -73,6 +73,7 @@ public struct Builder {
     }
   }
 
+  @discardableResult
   public func createCondFail(condition: Value, message: String) -> CondFailInst {
     return message._withBridgedStringRef { messageStr in
       let cf = bridged.createCondFail(condition.bridged, messageStr)
@@ -91,6 +92,11 @@ public struct Builder {
     return notifyNew(dr.getAs(AllocStackInst.self))
   }
 
+  public func createAllocVector(capacity: Value, elementType: Type) -> AllocVectorInst {
+    let dr = bridged.createAllocVector(capacity.bridged, elementType.bridged)
+    return notifyNew(dr.getAs(AllocVectorInst.self))
+  }
+
   @discardableResult
   public func createDeallocStack(_ operand: Value) -> DeallocStackInst {
     let dr = bridged.createDeallocStack(operand.bridged)
@@ -103,6 +109,12 @@ public struct Builder {
     return notifyNew(dr.getAs(DeallocStackRefInst.self))
   }
 
+  public func createAddressToPointer(address: Value, pointerType: Type,
+                                     needStackProtection: Bool) -> AddressToPointerInst {
+    let dr = bridged.createAddressToPointer(address.bridged, pointerType.bridged, needStackProtection)
+    return notifyNew(dr.getAs(AddressToPointerInst.self))
+  }
+
   public func createUncheckedRefCast(from value: Value, to type: Type) -> UncheckedRefCastInst {
     let cast = bridged.createUncheckedRefCast(value.bridged, type.bridged)
     return notifyNew(cast.getAs(UncheckedRefCastInst.self))
@@ -118,6 +130,11 @@ public struct Builder {
     return notifyNew(load.getAs(LoadInst.self))
   }
 
+  public func createLoadBorrow(fromAddress: Value) -> LoadBorrowInst {
+    let load = bridged.createLoadBorrow(fromAddress.bridged)
+    return notifyNew(load.getAs(LoadBorrowInst.self))
+  }
+
   public func createBeginDeallocRef(reference: Value, allocation: AllocRefInstBase) -> BeginDeallocRefInst {
     let beginDealloc = bridged.createBeginDeallocRef(reference.bridged, allocation.bridged)
     return notifyNew(beginDealloc.getAs(BeginDeallocRefInst.self))
@@ -280,6 +297,14 @@ public struct Builder {
     return notifyNew(objectInst.getAs(ObjectInst.self))
   }
 
+  @discardableResult
+  public func createVector(type: Type, arguments: [Value]) -> VectorInst {
+    let vectorInst = arguments.withBridgedValues { valuesRef in
+      return bridged.createVector(valuesRef)
+    }
+    return notifyNew(vectorInst.getAs(VectorInst.self))
+  }
+
   public func createGlobalAddr(global: GlobalVariable) -> GlobalAddrInst {
     return notifyNew(bridged.createGlobalAddr(global.bridged).getAs(GlobalAddrInst.self))
   }