Merge pull request #39673 from slavapestov/rqm-type-witness-recursion-hack

RequirementMachine: Tighten up type witness recursion hack

Author: slavapestov

lib/AST/RequirementMachine/PropertyMap.cpp

@@ -910,7 +910,19 @@ void PropertyMap::concretizeNestedTypesFromConcreteParent(
 
       MutableTerm constraintType;
 
-      if (concreteType == typeWitness &&
+      auto simplify = [&](CanType t) -> CanType {
+        return CanType(t.transformRec([&](Type t) -> Optional<Type> {
+          if (!t->isTypeParameter())
+            return None;
+
+          auto term = getRelativeTermForType(t->getCanonicalType(),
+                                             substitutions, Context);
+          System.simplify(term);
+          return Context.getTypeForTerm(term, { }, Protos);
+        }));
+      };
+
+      if (simplify(concreteType) == simplify(typeWitness) &&
           requirementKind == RequirementKind::SameType) {
         // FIXME: ConcreteTypeInDomainMap should support substitutions so
         // that we can remove this.

lib/AST/RequirementMachine/PropertyMap.h

@@ -139,6 +139,7 @@ class PropertyBag {
 /// Out-of-line methods are documented in PropertyMap.cpp.
 class PropertyMap {
   RewriteContext &Context;
+  RewriteSystem &System;
   std::vector<PropertyBag *> Entries;
   Trie<PropertyBag *, MatchKind::Longest> Trie;
 
@@ -156,10 +157,11 @@ class PropertyMap {
   PropertyMap &operator=(PropertyMap &&) = delete;
 
 public:
-  explicit PropertyMap(RewriteContext &ctx,
-                       const ProtocolGraph &protos)
-      : Context(ctx), Protos(protos) {
-    Debug = ctx.getDebugOptions();
+  explicit PropertyMap(RewriteSystem &system)
+      : Context(system.getRewriteContext()),
+        System(system),
+        Protos(system.getProtocols()) {
+    Debug = Context.getDebugOptions();
   }
 
   ~PropertyMap();

lib/AST/RequirementMachine/RequirementMachine.cpp

@@ -371,7 +371,7 @@ void RequirementMachine::dump(llvm::raw_ostream &out) const {
 }
 
 RequirementMachine::RequirementMachine(RewriteContext &ctx)
-    : Context(ctx), System(ctx), Map(ctx, System.getProtocols()) {
+    : Context(ctx), System(ctx), Map(System) {
   auto &langOpts = ctx.getASTContext().LangOpts;
   Dump = langOpts.DumpRequirementMachine;
   RequirementMachineStepLimit = langOpts.RequirementMachineStepLimit;

test/Generics/rdar83894546.swift

@@ -0,0 +1,33 @@
+// RUN: %target-typecheck-verify-swift
+
+public protocol P1 {
+  associatedtype A: P1 where A.A == A
+}
+
+public protocol P2 {
+  associatedtype B: P1
+  associatedtype C: P2
+}
+
+public struct G<B : P1> : P2 {
+  public typealias C = G<B.A>
+}
+
+// C == G<B> together with the definition of G<B>.C implies an infinite series
+// of rules:
+// - C.C == G<B.A>
+// - C.C.C == G<B.A.A>
+// - C.C.C.C == G<B.A.A.A>
+// - ...
+//
+// This would normally prevent the completion procedure from terminating,
+// however A.A == A in protocol P1 means that the right hand sides simplify
+// as follows:
+//
+// - C.C == G<B.A>
+// - C.C.C == B<G.A>
+// - C.C.C.C == G<B.A>
+// - ...
+//
+// Therefore, the single rule C.C == C.C.C suffices to "tie off" the recursion.
+public protocol P3: P2 where C == G<B> {}