[region-isolation] Rename callback handleFailure -> handleLocalUseAfterTransfer.

Now that we have other forms of error callbacks, having such a general name for
any specific failure is misleading and hinds intent.

Author: gottesmm

include/swift/SILOptimizer/Utils/PartitionUtils.h

@@ -1028,10 +1028,10 @@ struct PartitionOpEvaluator {
     return asImpl().shouldEmitVerboseLogging();
   }
 
-  /// Call handleFailure on our CRTP subclass.
-  void handleFailure(const PartitionOp &op, Element elt,
-                     TransferringOperand transferringOp) const {
-    return asImpl().handleFailure(op, elt, transferringOp);
+  /// Call handleLocalUseAfterTransfer on our CRTP subclass.
+  void handleLocalUseAfterTransfer(const PartitionOp &op, Element elt,
+                                   TransferringOperand transferringOp) const {
+    return asImpl().handleLocalUseAfterTransfer(op, elt, transferringOp);
   }
 
   /// Call handleTransferNonTransferrable on our CRTP subclass.
@@ -1086,7 +1086,8 @@ struct PartitionOpEvaluator {
       // value... emit an error.
       if (auto *transferredOperandSet = p.getTransferred(op.getOpArgs()[1])) {
         for (auto transferredOperand : transferredOperandSet->data()) {
-          handleFailure(op, op.getOpArgs()[1], transferredOperand);
+          handleLocalUseAfterTransfer(op, op.getOpArgs()[1],
+                                      transferredOperand);
         }
       }
       p.assignElement(op.getOpArgs()[0], op.getOpArgs()[1]);
@@ -1169,12 +1170,14 @@ struct PartitionOpEvaluator {
       // if attempting to merge a transferred region, handle the failure
       if (auto *transferredOperandSet = p.getTransferred(op.getOpArgs()[0])) {
         for (auto transferredOperand : transferredOperandSet->data()) {
-          handleFailure(op, op.getOpArgs()[0], transferredOperand);
+          handleLocalUseAfterTransfer(op, op.getOpArgs()[0],
+                                      transferredOperand);
         }
       }
       if (auto *transferredOperandSet = p.getTransferred(op.getOpArgs()[1])) {
         for (auto transferredOperand : transferredOperandSet->data()) {
-          handleFailure(op, op.getOpArgs()[1], transferredOperand);
+          handleLocalUseAfterTransfer(op, op.getOpArgs()[1],
+                                      transferredOperand);
         }
       }
 
@@ -1187,7 +1190,8 @@ struct PartitionOpEvaluator {
              "Require PartitionOp's argument should already be tracked");
       if (auto *transferredOperandSet = p.getTransferred(op.getOpArgs()[0])) {
         for (auto transferredOperand : transferredOperandSet->data()) {
-          handleFailure(op, op.getOpArgs()[0], transferredOperand);
+          handleLocalUseAfterTransfer(op, op.getOpArgs()[0],
+                                      transferredOperand);
         }
       }
       return;
@@ -1233,8 +1237,8 @@ struct PartitionOpEvaluatorBaseImpl : PartitionOpEvaluator<Subclass> {
   /// 3. The operand of the instruction that originally transferred the
   /// region. Can be used to get the immediate value transferred or the
   /// transferring instruction.
-  void handleFailure(const PartitionOp &op, Element elt,
-                     TransferringOperand transferringOp) const {}
+  void handleLocalUseAfterTransfer(const PartitionOp &op, Element elt,
+                                   TransferringOperand transferringOp) const {}
 
   /// This is called if we detect a never transferred element that was passed to
   /// a transfer instruction.

lib/SILOptimizer/Analysis/RegionAnalysis.cpp

@@ -3009,8 +3009,8 @@ bool BlockPartitionState::recomputeExitFromEntry(
   };
   ComputeEvaluator eval(workingPartition, ptrSetFactory, translator);
   for (const auto &partitionOp : blockPartitionOps) {
-    // By calling apply without providing a `handleFailure` closure, errors
-    // will be suppressed
+    // By calling apply without providing any error handling callbacks, errors
+    // will be surpressed.  will be suppressed
     eval.apply(partitionOp);
   }
   LLVM_DEBUG(llvm::dbgs() << "    Working Partition: ";

lib/SILOptimizer/Mandatory/TransferNonSendable.cpp

@@ -1261,9 +1261,9 @@ struct DiagnosticEvaluator final
         transferOpToRequireInstMultiMap(transferOpToRequireInstMultiMap),
         transferredNonTransferrable(transferredNonTransferrable) {}
 
-  void handleFailure(const PartitionOp &partitionOp,
-                     TrackableValueID transferredVal,
-                     TransferringOperand transferringOp) const {
+  void handleLocalUseAfterTransfer(const PartitionOp &partitionOp,
+                                   TrackableValueID transferredVal,
+                                   TransferringOperand transferringOp) const {
     // Ignore this if we have a gep like instruction that is returning a
     // sendable type and transferringOp was not set with closure
     // capture.

unittests/SILOptimizer/PartitionUtilsTest.cpp

@@ -542,8 +542,8 @@ struct PartitionOpEvaluatorWithFailureCallback final
       : PartitionOpEvaluatorBaseImpl(workingPartition, ptrSetFactory),
         failureCallback(failureCallback) {}
 
-  void handleFailure(const PartitionOp &op, Element elt,
-                     TransferringOperand transferringOp) const {
+  void handleLocalUseAfterTransfer(const PartitionOp &op, Element elt,
+                                   TransferringOperand transferringOp) const {
     failureCallback(op, elt, transferringOp);
   }
 };