Merge pull request #71301 from atrick/lifetime-diagnostics

[NFC] disable verbose lifetime diagnostics by default

Author: atrick

SwiftCompilerSources/Sources/Optimizer/FunctionPasses/LifetimeDependenceDiagnostics.swift

@@ -12,7 +12,7 @@
 
 import SIL
 
-private let verbose = true
+private let verbose = false
 
 private func log(_ message: @autoclosure () -> String) {
   if verbose {

lib/SILOptimizer/PassManager/PassPipeline.cpp

@@ -70,9 +70,9 @@ llvm::cl::opt<bool>
                           llvm::cl::desc("Enable the DestroyHoisting pass."));
 
 llvm::cl::opt<bool>
-DisableLifetimeDependenceDiagnostics(
-  "disable-lifetime-dependence-diagnostics", llvm::cl::init(false),
-  llvm::cl::desc("Disable lifetime dependence diagnostics."));
+EnableLifetimeDependenceDiagnostics(
+  "enable-lifetime-dependence-diagnostics", llvm::cl::init(false),
+  llvm::cl::desc("Enable lifetime dependence diagnostics."));
 
 //===----------------------------------------------------------------------===//
 //                          Diagnostic Pass Pipeline
@@ -168,7 +168,7 @@ static void addMandatoryDiagnosticOptPipeline(SILPassPipelinePlan &P) {
   P.addMoveOnlyChecker();
 
   // Check ~Escapable.
-  if (!DisableLifetimeDependenceDiagnostics) {
+  if (EnableLifetimeDependenceDiagnostics) {
     P.addLifetimeDependenceDiagnostics();
   }
   if (EnableDeinitDevirtualizer)