Merge pull request #73425 from DougGregor/task-group-next-public

Author: DougGregor

stdlib/public/Concurrency/TaskGroup.swift

@@ -574,10 +574,9 @@ public struct TaskGroup<ChildTaskResult: Sendable> {
     return try! await _taskGroupWaitNext(group: _group) // !-safe cannot throw, we're a non-throwing TaskGroup
   }
 
-  @usableFromInline
   @available(SwiftStdlib 5.1, *)
-  @_silgen_name("$sScG4nextxSgyYaF")
-  internal mutating func __abi_next() async -> ChildTaskResult? {
+  @_disfavoredOverload
+  public mutating func next() async -> ChildTaskResult? {
     // try!-safe because this function only exists for Failure == Never,
     // and as such, it is impossible to spawn a throwing child task.
     return try! await _taskGroupWaitNext(group: _group) // !-safe cannot throw, we're a non-throwing TaskGroup
@@ -1035,10 +1034,9 @@ public struct ThrowingTaskGroup<ChildTaskResult: Sendable, Failure: Error> {
     return try await _taskGroupWaitNext(group: _group)
   }
 
-  @usableFromInline
   @available(SwiftStdlib 5.1, *)
-  @_silgen_name("$sScg4nextxSgyYaKF")
-  internal mutating func __abi_next() async throws -> ChildTaskResult? {
+  @_disfavoredOverload
+  public mutating func next() async throws -> ChildTaskResult? {
     return try await _taskGroupWaitNext(group: _group)
   }
 

test/Concurrency/async_task_groups_as_sequence.swift

@@ -0,0 +1,22 @@
+// RUN: %target-swift-frontend  -disable-availability-checking %s -emit-sil -o /dev/null -verify
+// RUN: %target-swift-frontend  -disable-availability-checking %s -emit-sil -o /dev/null -verify -strict-concurrency=targeted
+// RUN: %target-swift-frontend  -disable-availability-checking %s -emit-sil -o /dev/null -verify -strict-concurrency=complete
+// RUN: %target-swift-frontend  -disable-availability-checking %s -emit-sil -o /dev/null -verify -strict-concurrency=complete -enable-upcoming-feature RegionBasedIsolation
+
+// REQUIRES: concurrency
+// REQUIRES: asserts
+// REQUIRES: libdispatch
+
+@available(SwiftStdlib 5.1, *)
+@rethrows
+protocol TGP: AsyncSequence, AsyncIteratorProtocol { }
+
+@available(SwiftStdlib 5.1, *)
+extension TaskGroup: TGP { }
+// expected-warning@-1{{extension declares a conformance of imported type 'TaskGroup' to imported protocol 'AsyncIteratorProtocol'}}
+// expected-note@-2{{add '@retroactive' to silence this warning}}
+
+@available(SwiftStdlib 5.1, *)
+extension ThrowingTaskGroup: TGP { }
+// expected-warning@-1{{extension declares a conformance of imported type 'ThrowingTaskGroup' to imported protocol 'AsyncIteratorProtocol'}}
+// expected-note@-2{{add '@retroactive' to silence this warning}}

test/api-digester/stability-concurrency-abi.test

@@ -112,14 +112,6 @@ Func TaskLocal.withValue(_:operation:file:line:) has parameter 1 type change fro
 Func TaskLocal.withValue(_:operation:file:line:) has parameter 2 type change from Swift.String to (any _Concurrency.Actor)?
 Func TaskLocal.withValue(_:operation:file:line:) has parameter 3 type change from Swift.UInt to Swift.String
 
-// The method is actually still there: '__abi_next' silgen_name("$sScG4nextxSgyYaF")
-Func TaskGroup.next() has been renamed to Func next(isolation:)
-Func TaskGroup.next() has mangled name changing from 'Swift.TaskGroup.next() async -> Swift.Optional<A>' to 'Swift.TaskGroup.next(isolation: isolated Swift.Optional<Swift.Actor>) async -> Swift.Optional<A>'
-
-// The method is actually still there: '__abi_next' silgen_name("$sScg4nextxSgyYaKF")
-Func ThrowingTaskGroup.next() has been renamed to Func next(isolation:)
-Func ThrowingTaskGroup.next() has mangled name changing from 'Swift.ThrowingTaskGroup.next() async throws -> Swift.Optional<A>' to 'Swift.ThrowingTaskGroup.next(isolation: isolated Swift.Optional<Swift.Actor>) async throws -> Swift.Optional<A>'
-
 // *** DO NOT DISABLE OR XFAIL THIS TEST. *** (See comment above.)