Merge pull request #83179 from xedin/rdar-128109889

[ASTVerifier] Allow `inout` and `Array` to pointer conversion in vari…

Author: xedin

lib/AST/ASTVerifier.cpp

@@ -1897,6 +1897,18 @@ class Verifier : public ASTWalker {
           continue;
         }
 
+        // If the argument is a concrete variadic expansion, let's check its
+        // every element.
+        if (auto *variadicExpansion = dyn_cast<VarargExpansionExpr>(subExpr)) {
+          if (auto *implicitArray =
+                  dyn_cast<ArrayExpr>(variadicExpansion->getSubExpr())) {
+            for (auto *element : implicitArray->getElements()) {
+              maybeRecordValidPointerConversionForArg(element);
+            }
+            return;
+          }
+        }
+
         break;
       }
 

test/SILGen/pointer_conversion.swift

@@ -481,3 +481,21 @@ public struct RefObj {
 public func objectFieldToPointer(rc: RefObj) {
   takeObjectPointer(&rc.o.object)
 }
+
+// CHECK-LABEL: sil [ossa] @$s18pointer_conversion21testVariadicParameter1aySaySiGz_tF : $@convention(thin) (@inout Array<Int>) -> ()
+// CHECK: [[ARRAY_REF:%.*]] = begin_access [modify] [unknown] %0 : $*Array<Int>
+// CHECK: [[CONVERT_ARRAY_TO_POINTER:%.*]] = function_ref @$ss37_convertMutableArrayToPointerArgumentyyXlSg_q_tSayxGzs01_E0R_r0_lF
+// CHECK: apply [[CONVERT_ARRAY_TO_POINTER]]<Int, UnsafeMutableRawPointer>({{.*}}, [[ARRAY_REF]])
+// CHECK: [[V_REF:%.*]] = begin_access [modify] [unknown] %28 : $*Double
+// CHECK: [[DOUBLE_AS_PTR:%.*]] = address_to_pointer [stack_protection] [[V_REF]] : $*Double to $Builtin.RawPointer
+// CHECK: [[INOUT_TO_PTR:%.*]] = function_ref @$ss30_convertInOutToPointerArgumentyxBps01_E0RzlF
+// CHECK: apply [[INOUT_TO_PTR]]<UnsafeMutableRawPointer>(%39, [[DOUBLE_AS_PTR]])
+// CHECK: } // end sil function '$s18pointer_conversion21testVariadicParameter1aySaySiGz_tF'
+public func testVariadicParameter(a: inout [Int]) {
+  func test(_ : UnsafeMutableRawPointer?...) {}
+
+  test(&a)
+
+  var v: Double
+  test(&v)
+}

validation-test/Sema/type_checker_crashers_fixed/issue-73454.swift

@@ -0,0 +1,21 @@
+// RUN: %target-typecheck-verify-swift
+
+// https://github.com/apple/swift/issues/73454
+
+func object_method_bind_ptrcall_v(
+  _: UnsafeMutableRawPointer?...
+) {
+}
+
+func setDensity(_ density: Double, ptr: UnsafeMutableRawPointer) {
+  var copy_density = density
+  var arr: [Int] = []
+
+  object_method_bind_ptrcall_v(&copy_density)
+  object_method_bind_ptrcall_v(&arr)
+
+  object_method_bind_ptrcall_v(&arr, &copy_density)
+
+  object_method_bind_ptrcall_v(ptr, &copy_density, &arr)
+  object_method_bind_ptrcall_v(&copy_density, ptr, &arr)
+}

validation-test/compiler_crashers_2/2ae771dc466f1acc.swift renamed to validation-test/compiler_crashers_2_fixed/2ae771dc466f1acc.swift

@@ -1,5 +1,5 @@
 // {"kind":"typecheck","original":"f0cca09d","signature":"swift::ASTWalker::PostWalkResult<swift::ArrayToPointerExpr*> (anonymous namespace)::Verifier::dispatchVisitPost<swift::ArrayToPointerExpr*>(swift::ArrayToPointerExpr*)"}
-// RUN: not --crash %target-swift-frontend -typecheck %s
+// RUN: %target-typecheck-verify-swift
 struct a {
   var b: String
 }