Serialization: Fix PackConformance deserialization

Author: slavapestov

lib/Serialization/Deserialization.cpp

@@ -871,8 +871,8 @@ ModuleFile::getConformanceChecked(ProtocolConformanceID conformanceID) {
 
   case SerializedProtocolConformanceKind::Pack: {
     auto conformanceIndex = (conformanceID >> SerializedProtocolConformanceKind::Shift) - 1;
-    assert(conformanceIndex < Conformances.size() && "invalid pack conformance ID");
-    auto &conformanceOrOffset = Conformances[conformanceIndex];
+    assert(conformanceIndex < PackConformances.size() && "invalid pack conformance ID");
+    auto &conformanceOrOffset = PackConformances[conformanceIndex];
     if (!conformanceOrOffset.isComplete()) {
       BCOffsetRAII restoreOffset(DeclTypeCursor);
       if (auto error = diagnoseFatalIfNotSuccess(

lib/Serialization/ModuleFile.cpp

@@ -110,6 +110,7 @@ ModuleFile::ModuleFile(std::shared_ptr<const ModuleFileSharedCore> core)
   allocateBuffer(Decls, core->Decls);
   allocateBuffer(LocalDeclContexts, core->LocalDeclContexts);
   allocateBuffer(Conformances, core->Conformances);
+  allocateBuffer(PackConformances, core->PackConformances);
   allocateBuffer(SILLayouts, core->SILLayouts);
   allocateBuffer(Types, core->Types);
   allocateBuffer(ClangTypes, core->ClangTypes);

test/SIL/Serialization/pack_expansion_type.swift

@@ -1,6 +1,6 @@
 // RUN: %empty-directory(%t)
 // RUN: %target-swift-frontend -emit-module %s -emit-module-path %t/pack_expansion_type.swiftmodule -DLIB -enable-experimental-feature VariadicGenerics
-// RUN: %target-swift-frontend -emit-sil %s -I %t -DAPP -module-name main -enable-experimental-feature VariadicGenerics
+// RUN: %target-swift-frontend -emit-ir %s -I %t -DAPP -module-name main -enable-experimental-feature VariadicGenerics
 
 // Because of -enable-experimental-feature VariadicGenerics
 // REQUIRES: asserts
@@ -25,10 +25,9 @@ public func transparentCaller2() {
   transparentCaller(1, "hi", false)
 }
 
-public func calleeWithRequirement<each T: Equatable>(_: repeat each T) {}
-
-@_transparent public func callerWithRequirement(x: Int, y: String) {
-  calleeWithRequirement(x, y)
+@_alwaysEmitIntoClient
+public func calleeWithRequirement<each T: Equatable>(_ t: repeat each T) {
+  repeat ((each t) == (each t))
 }
 
 #elseif APP
@@ -37,6 +36,6 @@ import pack_expansion_type
 
 transparentCaller(1, "hi", false)
 serializedCaller(1, "hi", false)
-callerWithRequirement(x: 1, y: "hi")
+calleeWithRequirement(1, "hi")
 
 #endif