Merge pull request #83367 from eeckstein/context-refactor

SwiftCompilerSources: move the `Context` and `MutatingContext` protocols from the Optimizer to the SIL module

Author: eeckstein

SwiftCompilerSources/Sources/Optimizer/Analysis/AliasAnalysis.swift

@@ -15,7 +15,7 @@ import SIL
 
 extension FunctionPassContext {
   var aliasAnalysis: AliasAnalysis {
-    let bridgedAA = _bridged.getAliasAnalysis()
+    let bridgedAA = bridgedPassContext.getAliasAnalysis()
     return AliasAnalysis(bridged: bridgedAA, context: self)
   }
 }
@@ -113,15 +113,15 @@ struct AliasAnalysis {
         bridgedAliasAnalysis.mutableCachePointer.assumingMemoryBound(to: Cache.self).deinitialize(count: 1)
       },
       // getMemEffectsFn
-      { (bridgedCtxt: BridgedPassContext,
+      { (bridgedCtxt: BridgedContext,
          bridgedAliasAnalysis: BridgedAliasAnalysis,
          bridgedAddr: BridgedValue,
          bridgedInst: BridgedInstruction) -> BridgedMemoryBehavior in
         let aa = AliasAnalysis(bridged: bridgedAliasAnalysis, context: FunctionPassContext(_bridged: bridgedCtxt))
         return aa.getMemoryEffect(of: bridgedInst.instruction, on: bridgedAddr.value).bridged
       },
       // isObjReleasedFn
-      { (bridgedCtxt: BridgedPassContext,
+      { (bridgedCtxt: BridgedContext,
          bridgedAliasAnalysis: BridgedAliasAnalysis,
          bridgedObj: BridgedValue,
          bridgedInst: BridgedInstruction) -> Bool in
@@ -142,7 +142,7 @@ struct AliasAnalysis {
       },
 
       // isAddrVisibleFromObj
-      { (bridgedCtxt: BridgedPassContext,
+      { (bridgedCtxt: BridgedContext,
          bridgedAliasAnalysis: BridgedAliasAnalysis,
          bridgedAddr: BridgedValue,
          bridgedObj: BridgedValue) -> Bool in
@@ -159,7 +159,7 @@ struct AliasAnalysis {
       },
 
       // mayAliasFn
-      { (bridgedCtxt: BridgedPassContext,
+      { (bridgedCtxt: BridgedContext,
          bridgedAliasAnalysis: BridgedAliasAnalysis,
          bridgedLhs: BridgedValue,
          bridgedRhs: BridgedValue) -> Bool in

SwiftCompilerSources/Sources/Optimizer/DataStructures/CMakeLists.txt

@@ -7,11 +7,6 @@
 # See http://swift.org/CONTRIBUTORS.txt for Swift project authors
 
 swift_compiler_sources(Optimizer
-  BasicBlockRange.swift
   DeadEndBlocks.swift
   FunctionUses.swift
-  InstructionRange.swift
-  ReachableBlocks.swift
-  Set.swift
-  Stack.swift
-  Worklist.swift)
+  ReachableBlocks.swift)

SwiftCompilerSources/Sources/Optimizer/FunctionPasses/AllocBoxToStack.swift

@@ -102,7 +102,7 @@ private func tryConvertBoxesToStack(in function: Function, _ context: FunctionPa
     hoistMarkUnresolvedInsts(stackAddress: stack, checkKind: .consumableAndAssignable, context)
   }
   if !promotableBoxes.isEmpty {
-    function.fixStackNesting(context)
+    context.fixStackNesting(in: function)
   }
 
   return functionsToSpecialize

SwiftCompilerSources/Sources/Optimizer/FunctionPasses/ClosureSpecialization.swift

@@ -158,7 +158,7 @@ let autodiffClosureSpecialization = FunctionPass(name: "autodiff-closure-special
     }
 
     if context.needFixStackNesting {
-      function.fixStackNesting(context)
+      context.fixStackNesting(in: function)
     }
 
     remainingSpecializationRounds -= 1
@@ -836,7 +836,7 @@ private extension SpecializationCloner {
     }
 
     if (self.context.needFixStackNesting) {
-      self.cloned.fixStackNesting(self.context)
+      self.context.fixStackNesting(in: self.cloned)
     }
   }
 }

SwiftCompilerSources/Sources/Optimizer/FunctionPasses/ComputeEscapeEffects.swift

@@ -72,7 +72,7 @@ let computeEscapeEffects = FunctionPass(name: "compute-escape-effects") {
     return
   }
 
-  context.modifyEffects(in: function) { (effects: inout FunctionEffects) in
+  function.modifyEffects(context) { (effects: inout FunctionEffects) in
     effects.escapeEffects.arguments = newEffects
   }
 }

SwiftCompilerSources/Sources/Optimizer/FunctionPasses/ComputeSideEffects.swift

@@ -69,7 +69,7 @@ let computeSideEffects = FunctionPass(name: "compute-side-effects") {
   }
 
   // Finally replace the function's side effects.
-  context.modifyEffects(in: function) { (effects: inout FunctionEffects) in
+  function.modifyEffects(context) { (effects: inout FunctionEffects) in
     let globalEffects = function.isProgramTerminationPoint ?
                             collectedEffects.globalEffects.forProgramTerminationPoints
                           : collectedEffects.globalEffects

SwiftCompilerSources/Sources/Optimizer/FunctionPasses/SimplificationPasses.swift

@@ -110,7 +110,7 @@ func runSimplification(on function: Function, _ context: FunctionPassContext,
   } while !worklist.isEmpty
 
   if context.needFixStackNesting {
-    function.fixStackNesting(context)
+    context.fixStackNesting(in: function)
   }
 
   return changed

SwiftCompilerSources/Sources/Optimizer/FunctionPasses/StackPromotion.swift

@@ -57,7 +57,7 @@ let stackPromotion = FunctionPass(name: "stack-promotion") {
   }
   if needFixStackNesting {
     // Make sure that all stack allocating instructions are nested correctly.
-    function.fixStackNesting(context)
+    context.fixStackNesting(in: function)
   }
 }
 

SwiftCompilerSources/Sources/Optimizer/InstructionSimplification/SimplifyBuiltin.swift

@@ -56,7 +56,7 @@ extension BuiltinInst : OnoneSimplifiable, SILCombineSimplifiable {
       case .Xor:
         simplifyNegation(context)
       default:
-        if let literal = constantFold(context) {
+        if let literal = context.constantFold(builtin: self) {
           uses.replaceAll(with: literal, context)
         }
     }
@@ -240,7 +240,7 @@ private extension BuiltinInst {
     if constantFoldStringNullPointerCheck(isEqual: isEqual, context) {
       return
     }
-    if let literal = constantFold(context) {
+    if let literal = context.constantFold(builtin: self) {
       uses.replaceAll(with: literal, context)
     }
   }

SwiftCompilerSources/Sources/Optimizer/ModulePasses/StackProtection.swift

@@ -113,7 +113,7 @@ private struct StackProtectionOptimization {
       process(instruction: inst, in: function, mustFixStackNesting: &mustFixStackNesting, context)
     }
     if mustFixStackNesting {
-      function.fixStackNesting(context)
+      context.fixStackNesting(in: function)
     }
   }