Merge pull request #42436 from CodaFi/hypertextualism

Remove Bogus Macro Assert in LUT Building

Author: CodaFi

lib/ClangImporter/SwiftLookupTable.cpp

@@ -1969,12 +1969,6 @@ void importer::addMacrosToLookupTable(SwiftLookupTable &table,
 
       // If we're in a module, we really need moduleMacro to be valid.
       if (isModule && !moduleMacro) {
-#ifndef NDEBUG
-        // Refetch this just for the assertion.
-        clang::MacroDirective *MD = pp.getLocalMacroDirective(macro.first);
-        assert(isa<clang::VisibilityMacroDirective>(MD));
-#endif
-
         // FIXME: "public" visibility macros should actually be added to the 
         // table.
         return;

test/ClangImporter/Inputs/custom-modules/TextualHeaders.framework/Modules/module.modulemap

@@ -0,0 +1,12 @@
+framework module TextualHeaders [system] {
+  umbrella "PrivateHeaders"
+  
+  explicit module TextualHeader {
+    textual header "TextualHeader.h"
+    export *
+  }
+
+  explicit module * { export * }
+
+  export_as TextualHeaders_Private
+}

test/ClangImporter/Inputs/custom-modules/TextualHeaders.framework/PrivateHeaders/TextualHeader.h

@@ -0,0 +1 @@
+#define BOOM 42

test/ClangImporter/textual_headers.swift

@@ -0,0 +1,2 @@
+// RUN: %target-swift-frontend(mock-sdk: %clang-importer-sdk) -enable-objc-interop -typecheck -F %S/Inputs/custom-modules %s -verify
+import TextualHeaders