[gardening] fix warnings in tests

Author: glessard

test/stdlib/UnsafePointer.swift.gyb

@@ -29,7 +29,7 @@ extension UnsafeMutablePointer where Pointee : TestProtocol1 {
 }
 
 // Check that the generic parameter is called 'Element'.
-extension UnsafeBufferPointerIterator where Element : TestProtocol1 {
+extension UnsafeBufferPointer.Iterator where Element : TestProtocol1 {
   var _elementIsTestProtocol1: Bool {
     fatalError("not implemented")
   }
@@ -358,7 +358,7 @@ UnsafeMutablePointerTestSuite.test("initialize:from:.Right") {
 }
 
 UnsafeMutablePointerTestSuite.test("initialize:from:/immutable") {
-  var ptr = UnsafeMutablePointer<Missile>.allocate(capacity: 3)
+  let ptr = UnsafeMutablePointer<Missile>.allocate(capacity: 3)
   defer {
     ptr.deinitialize(count: 3)
     ptr.deallocate()
@@ -373,7 +373,7 @@ UnsafeMutablePointerTestSuite.test("initialize:from:/immutable") {
 }
 
 UnsafeMutablePointerTestSuite.test("assign/immutable") {
-  var ptr = UnsafeMutablePointer<Missile>.allocate(capacity: 2)
+  let ptr = UnsafeMutablePointer<Missile>.allocate(capacity: 2)
   defer {
     ptr.deinitialize(count: 2)
     ptr.deallocate()
@@ -463,9 +463,9 @@ ${SelfName}TestSuite.test("withMemoryRebound") {
   let ptrI = ${SelfName}<Int>(mutablePtrI)
   ptrI.withMemoryRebound(to: UInt.self, capacity: 4) {
     // Make sure the closure argument isa $SelfName
-    var ptrU: ${SelfName}<UInt> = $0
+    let ptrU: ${SelfName}<UInt> = $0
     // and that the element type is UInt.
-    var mutablePtrU = UnsafeMutablePointer(mutating: ptrU)
+    let mutablePtrU = UnsafeMutablePointer(mutating: ptrU)
     expectType(UInt.self, &mutablePtrU.pointee)
   }
 }

test/stdlib/UnsafeRawPointer.swift

@@ -17,7 +17,7 @@ UnsafeMutableRawPointerExtraTestSuite.test("initializeMemory") {
   Missile.missilesLaunched = 0
   do {
     let sizeInBytes = 3 * MemoryLayout<Missile>.stride
-    var p1 = UnsafeMutableRawPointer.allocate(
+    let p1 = UnsafeMutableRawPointer.allocate(
       byteCount: sizeInBytes, alignment: MemoryLayout<Missile>.alignment)
     defer {
       p1.deallocate()
@@ -28,7 +28,7 @@ UnsafeMutableRawPointerExtraTestSuite.test("initializeMemory") {
     expectEqual(2, ptrM[1].number)
     expectEqual(2, ptrM[2].number)
 
-    var p2 = UnsafeMutableRawPointer.allocate(
+    let p2 = UnsafeMutableRawPointer.allocate(
       byteCount: sizeInBytes, alignment: MemoryLayout<Missile>.alignment)
     defer {
       p2.deallocate()
@@ -56,25 +56,25 @@ UnsafeMutableRawPointerExtraTestSuite.test("initializeMemory") {
 
 UnsafeMutableRawPointerExtraTestSuite.test("bindMemory") {
   let sizeInBytes = 3 * MemoryLayout<Int>.stride
-  var p1 = UnsafeMutableRawPointer.allocate(
+  let p1 = UnsafeMutableRawPointer.allocate(
     byteCount: sizeInBytes, alignment: MemoryLayout<Int>.alignment)
   defer {
     p1.deallocate()
   }
   let ptrI = p1.bindMemory(to: Int.self, capacity: 3)
   let bufI = UnsafeMutableBufferPointer(start: ptrI, count: 3)
-  bufI.initialize(from: 1...3)
+  _ = bufI.initialize(from: 1...3)
   let ptrU = p1.bindMemory(to: UInt.self, capacity: 3)
   expectEqual(1, ptrU[0])
   expectEqual(2, ptrU[1])
   expectEqual(3, ptrU[2])
   let ptrU2 = p1.assumingMemoryBound(to: UInt.self)
-  expectEqual(1, ptrU[0])
+  expectEqual(1, ptrU2[0])
 }
 
 UnsafeMutableRawPointerExtraTestSuite.test("load/store") {
   let sizeInBytes = 3 * MemoryLayout<Int>.stride
-  var p1 = UnsafeMutableRawPointer.allocate(
+  let p1 = UnsafeMutableRawPointer.allocate(
     byteCount: sizeInBytes, alignment: MemoryLayout<Int>.alignment)
   defer {
     p1.deallocate()
@@ -96,7 +96,7 @@ UnsafeMutableRawPointerExtraTestSuite.test("load/store") {
 
 UnsafeMutableRawPointerExtraTestSuite.test("copyMemory") {
   let sizeInBytes = 4 * MemoryLayout<Int>.stride
-  var rawPtr = UnsafeMutableRawPointer.allocate(
+  let rawPtr = UnsafeMutableRawPointer.allocate(
     byteCount: sizeInBytes, alignment: MemoryLayout<Int>.alignment)
   defer {
     rawPtr.deallocate()