Merge pull request #80244 from DougGregor/diags-url-recognition

[Diagnostics] Fix recognition of URLs in category file/URL

Author: DougGregor

lib/ASTGen/Sources/ASTGen/DiagnosticsBridge.swift

@@ -407,11 +407,17 @@ extension String {
   /// Simple check to determine whether the string looks like the start of a
   /// URL.
   fileprivate var looksLikeURL: Bool {
+    var sawColon: Bool = false
     var forwardSlashes: Int = 0
     for c in self {
-      if c == "/" {
+      if c == ":" {
+        sawColon = true
+        continue
+      }
+
+      if c == "/" && sawColon {
         forwardSlashes += 1
-        if forwardSlashes > 2 {
+        if forwardSlashes >= 2 {
           return true
         }
 
@@ -420,6 +426,7 @@ extension String {
 
       if c.isLetter || c.isNumber {
         forwardSlashes = 0
+        sawColon = false
         continue
       }
 

test/diagnostics/print-diagnostic-groups.swift

@@ -1,4 +1,5 @@
-// RUN: %target-swift-frontend -typecheck %s 2>&1 | %FileCheck %s --check-prefix=CHECK
+// RUN: %target-swift-frontend -typecheck %s 2>&1 | %FileCheck %s --check-prefix=CHECK-FILE -check-prefix CHECK
+// RUN: %target-swift-frontend -typecheck %s -diagnostic-documentation-path https://www.swift.org/documentation/compiler/diagnostics/ 2>&1 | %FileCheck %s --check-prefix=CHECK-HTTPS -check-prefix CHECK
 // REQUIRES: swift_swift_parser
 
 // CHECK: warning: file 'print-diagnostic-groups.swift' is part of module 'main'; ignoring import{{$}}
@@ -13,4 +14,6 @@ func bar() {
 // CHECK: warning: 'bar()' is deprecated: renamed to 'bar2' [#DeprecatedDeclaration]{{$}}
 bar()
 
-// CHECK: [#DeprecatedDeclarations]: <{{.*}}deprecated-declaration.md>
+// CHECK-FILE: [#DeprecatedDeclarations]: <file://{{.*}}deprecated-declaration.md>
+
+// CHECK-HTTPS: [#DeprecatedDeclaration]: <https://www.swift.org/documentation/compiler/diagnostics/deprecated-declaration.md>