[embedded] #if the entire _BridgeStorage struct instead of sprinkling a bunch of #ifs inside

Author: kubamracek

stdlib/public/core/BridgeStorage.swift

@@ -20,6 +20,8 @@
 //===----------------------------------------------------------------------===//
 import SwiftShims
 
+#if !$Embedded
+
 @frozen
 @usableFromInline
 internal struct _BridgeStorage<NativeClass: AnyObject> {
@@ -31,15 +33,9 @@ internal struct _BridgeStorage<NativeClass: AnyObject> {
 
   // rawValue is passed inout to _isUnique.  Although its value
   // is unchanged, it must appear mutable to the optimizer.
-#if !$Embedded
   @usableFromInline
   internal var rawValue: Builtin.BridgeObject
-#else
-  @usableFromInline
-  internal var rawValue: NativeClass
-#endif
 
-#if !$Embedded
   @inlinable
   @inline(__always)
   internal init(native: Native, isFlagged flag: Bool) {
@@ -52,16 +48,13 @@ internal struct _BridgeStorage<NativeClass: AnyObject> {
       native,
       flag ? (1 as UInt) << _objectPointerLowSpareBitShift : 0)
   }
-#endif
 
-#if _runtime(_ObjC)
   @inlinable
   @inline(__always)
   internal init(objC: ObjC) {
     _internalInvariant(_usesNativeSwiftReferenceCounting(NativeClass.self))
     rawValue = _makeObjCBridgeObject(objC)
   }
-#endif
 
   @inlinable
   @inline(__always)
@@ -74,11 +67,7 @@ internal struct _BridgeStorage<NativeClass: AnyObject> {
   @inlinable
   @inline(__always)
   internal init(taggedPayload: UInt) {
-    #if !$Embedded
     rawValue = _bridgeObject(taggingPayload: taggedPayload)
-    #else
-    rawValue = Builtin.reinterpretCast(taggedPayload)
-    #endif
   }
 #endif
 
@@ -97,13 +86,9 @@ internal struct _BridgeStorage<NativeClass: AnyObject> {
   @inlinable
   internal var isNative: Bool {
     @inline(__always) get {
-      #if !$Embedded
       let result = Builtin.classifyBridgeObject(rawValue)
       return !Bool(Builtin.or_Int1(result.isObjCObject,
                                    result.isObjCTaggedPointer))
-      #else
-      return true
-      #endif
     }
   }
 
@@ -117,13 +102,9 @@ internal struct _BridgeStorage<NativeClass: AnyObject> {
   @inlinable
   internal var isUnflaggedNative: Bool {
     @inline(__always) get {
-      #if !$Embedded
       return (_bitPattern(rawValue) &
         (_bridgeObjectTaggedPointerBits | _objCTaggedPointerBits |
           _objectPointerIsObjCBit | _BridgeStorage.flagMask)) == 0
-      #else
-      return true
-      #endif
     }
   }
 
@@ -138,26 +119,16 @@ internal struct _BridgeStorage<NativeClass: AnyObject> {
   internal var nativeInstance: Native {
     @inline(__always) get {
       _internalInvariant(isNative)
-      #if !$Embedded
       return Builtin.castReferenceFromBridgeObject(rawValue)
-      #else
-      return rawValue
-      #endif
     }
   }
 
   @inlinable
   internal var unflaggedNativeInstance: Native {
     @inline(__always) get {
       _internalInvariant(isNative)
-      #if !$Embedded
       _internalInvariant(_nonPointerBits(rawValue) == 0)
-      #endif
-      #if !$Embedded
       return Builtin.reinterpretCast(rawValue)
-      #else
-      return rawValue
-      #endif
     }
   }
 
@@ -182,13 +153,93 @@ internal struct _BridgeStorage<NativeClass: AnyObject> {
     Builtin.endCOWMutation(&rawValue)
   }
 
-#if _runtime(_ObjC)
   @inlinable
   internal var objCInstance: ObjC {
     @inline(__always) get {
       _internalInvariant(isObjC)
       return Builtin.castReferenceFromBridgeObject(rawValue)
     }
   }
+}
+
+#else
+
+@frozen
+@usableFromInline
+internal struct _BridgeStorage<NativeClass: AnyObject> {
+  @usableFromInline
+  internal typealias Native = NativeClass
+
+  // rawValue is passed inout to _isUnique.  Although its value
+  // is unchanged, it must appear mutable to the optimizer.
+  @usableFromInline
+  internal var rawValue: NativeClass
+
+  @inlinable
+  @inline(__always)
+  internal init(native: Native) {
+    _internalInvariant(_usesNativeSwiftReferenceCounting(NativeClass.self))
+    rawValue = Builtin.reinterpretCast(native)
+  }
+
+#if _pointerBitWidth(_64)
+  @inlinable
+  @inline(__always)
+  internal init(taggedPayload: UInt) {
+    rawValue = Builtin.reinterpretCast(taggedPayload)
+  }
 #endif
+
+  @inlinable
+  @inline(__always)
+  internal mutating func isUniquelyReferencedNative() -> Bool {
+    return _isUnique(&rawValue)
+  }
+
+  @_alwaysEmitIntoClient
+  @inline(__always)
+  internal mutating func beginCOWMutationNative() -> Bool {
+    return Bool(Builtin.beginCOWMutation(&rawValue))
+  }
+
+  @inlinable
+  static var flagMask: UInt {
+    @inline(__always) get {
+      return (1 as UInt) << _objectPointerLowSpareBitShift
+    }
+  }
+
+  @inlinable
+  internal var nativeInstance: Native {
+    @inline(__always) get {
+      return rawValue
+    }
+  }
+
+  @inlinable
+  internal var unflaggedNativeInstance: Native {
+    @inline(__always) get {
+      return rawValue
+    }
+  }
+
+  @inlinable
+  @inline(__always)
+  internal mutating func isUniquelyReferencedUnflaggedNative() -> Bool {
+    return _isUnique_native(&rawValue)
+  }
+
+  @_alwaysEmitIntoClient
+  @inline(__always)
+  internal mutating func beginCOWMutationUnflaggedNative() -> Bool {
+    return Bool(Builtin.beginCOWMutation_native(&rawValue))
+  }
+
+  @_alwaysEmitIntoClient
+  @inline(__always)
+  internal mutating func endCOWMutation() {
+    Builtin.endCOWMutation(&rawValue)
+  }
 }
+
+#endif