Merge pull request #79161 from jckarter/end-apply-coroutine-iterator-invalidation

IRGen: Fix DenseMap interior pointer invalidation bug in IRGenSILFunction::visitEndApply.

Author: jckarter

lib/IRGen/IRGenSIL.cpp

@@ -4787,20 +4787,25 @@ void IRGenSILFunction::visitEndApply(BeginApplyInst *i, EndApplyInst *ei) {
       llvm::ConstantInt::get(IGM.Int1Ty, isAbort)
     });
 
+  // Destroy the temporaries before setting the lowered value for `ei`, since
+  // `setLoweredExplosion` will insert into the LoweredValues DenseMap and
+  // invalidate the `coroutine` reference.
+  coroutine.Temporaries.destroyAll(*this);
+  emitDeallocYieldOnceCoroutineBuffer(*this, coroutine.Buffer);
+
   if (!isAbort) {
     auto resultType = call->getType();
     if (!resultType->isVoidTy()) {
       Explosion e;
       // FIXME: Do we need to handle ABI-related conversions here?
       // It seems we cannot have C function convention for coroutines, etc.
       extractScalarResults(*this, resultType, call, e);
+      
+      // NOTE: This inserts a new entry into the LoweredValues DenseMap,
+      // invalidating the reference held by `coroutine`.
       setLoweredExplosion(ei, e);
     }
   }
-
-  coroutine.Temporaries.destroyAll(*this);
-
-  emitDeallocYieldOnceCoroutineBuffer(*this, coroutine.Buffer);
 }
 
 static llvm::BasicBlock *emitBBMapForSwitchValue(

test/AutoDiff/validation-test/modify_accessor.swift

@@ -1,5 +1,3 @@
-// REQUIRES: rdar144216380
-
 // RUN: %target-run-simple-swift
 // REQUIRES: executable_test