Noncopyable: deprecate '@_moveOnly' attribute

This hidden attribute is a leftover from before the '~Copyable' syntax.

rdar://130526083

Author: kavon

include/swift/AST/DiagnosticsSema.def

@@ -7743,6 +7743,8 @@ ERROR(noncopyable_objc_enum, none,
       "noncopyable enums cannot be marked '@objc'", ())
 ERROR(moveOnly_not_allowed_here,none,
       "'@_moveOnly' attribute is only valid on structs or enums", ())
+ERROR(moveOnly_deprecated,none,
+      "'@_moveOnly' attribute is deprecated and will be removed; use '~Copyable' instead", ())
 ERROR(consume_expression_needed_for_cast,none,
       "implicit conversion to %0 is consuming", (Type))
 NOTE(add_consume_to_silence,none,

lib/Sema/TypeCheckAttr.cpp

@@ -2546,6 +2546,12 @@ void AttributeChecker::visitFinalAttr(FinalAttr *attr) {
 }
 
 void AttributeChecker::visitMoveOnlyAttr(MoveOnlyAttr *attr) {
+  // This attribute is deprecated and slated for removal.
+  diagnose(attr->getLocation(), diag::moveOnly_deprecated)
+    .fixItRemove(attr->getRange())
+    .warnInSwiftInterface(D->getDeclContext());
+
+
   if (isa<StructDecl>(D) || isa<EnumDecl>(D))
     return;
 

stdlib/public/Concurrency/PartialAsyncTask.swift

@@ -193,8 +193,7 @@ extension UnownedJob: CustomStringConvertible {
 @available(SwiftStdlib 5.9, *)
 @available(*, deprecated, renamed: "ExecutorJob")
 @frozen
-@_moveOnly
-public struct Job: Sendable {
+public struct Job: Sendable, ~Copyable {
   internal var context: Builtin.Job
 
   @usableFromInline
@@ -262,8 +261,7 @@ extension Job {
 /// you don't generally interact with jobs directly.
 @available(SwiftStdlib 5.9, *)
 @frozen
-@_moveOnly
-public struct ExecutorJob: Sendable {
+public struct ExecutorJob: Sendable, ~Copyable {
   internal var context: Builtin.Job
 
   @usableFromInline

test/Sema/moveonly_decl_attr.swift

@@ -1,26 +1,27 @@
-// RUN: %target-typecheck-verify-swift -parse-stdlib -disable-availability-checking
-
-import Swift
+// RUN: %target-typecheck-verify-swift -disable-availability-checking
 
+// expected-error@+1 {{'@_moveOnly' attribute is deprecated and will be removed; use '~Copyable' instead}}
 @_moveOnly class C { // expected-error {{'@_moveOnly' attribute is only valid on structs or enums}}{{1-12=}}
     @_moveOnly // expected-error {{'@_moveOnly' attribute cannot be applied to this declaration}}
     func foo() {}
 }
 
-@_moveOnly
-struct S {
+// expected-error@+1 {{'@_moveOnly' attribute is deprecated and will be removed; use '~Copyable' instead}}
+@_moveOnly struct S {
     @_moveOnly // expected-error {{'@_moveOnly' attribute cannot be applied to this declaration}}
     func foo() {}
 }
 
-@_moveOnly
-enum E {
+// expected-error@+1 {{'@_moveOnly' attribute is deprecated and will be removed; use '~Copyable' instead}}
+@_moveOnly enum E {
     @_moveOnly // expected-error {{'@_moveOnly' attribute cannot be applied to this declaration}}
     func foo() {}
 }
 
 @_moveOnly let l = C()  // expected-error {{'@_moveOnly' attribute cannot be applied to this declaration}}
 
+// expected-error@+1 {{'@_moveOnly' attribute is deprecated and will be removed; use '~Copyable' instead}}
 @_moveOnly protocol P {} // expected-error {{'@_moveOnly' attribute is only valid on structs or enums}}{{1-12=}}
+// expected-error@+1 {{'@_moveOnly' attribute is deprecated and will be removed; use '~Copyable' instead}}
 @_moveOnly actor A {} // expected-error {{'@_moveOnly' attribute is only valid on structs or enums}}{{1-12=}}
 @_moveOnly extension C {} // expected-error {{'@_moveOnly' attribute cannot be applied to this declaration}}{{1-12=}}