Merge pull request #36627 from eeckstein/duplicate-silfunc-diagnostic

diagnose duplicated @_cdecl and @_silgen_name function names

Author: eeckstein

include/swift/AST/DiagnosticsSIL.def

@@ -43,6 +43,10 @@ ERROR(bridging_objcbridgeable_broken,none,
       "broken definition of '_ObjectiveCBridgeable' protocol: missing %0",
       (DeclName))
 
+ERROR(sil_function_redefinition,none,
+      "multiple definitions of symbol '%0'",
+      (StringRef))
+
 ERROR(invalid_sil_builtin,none,
       "INTERNAL ERROR: invalid use of builtin: %0",
       (StringRef))

lib/SIL/IR/SILFunctionBuilder.cpp

@@ -164,8 +164,14 @@ SILFunction *SILFunctionBuilder::getOrCreateFunction(
   SILLinkage linkage = constant.getLinkage(forDefinition);
 
   if (auto fn = mod.lookUpFunction(nameTmp)) {
-    assert(fn->getLoweredFunctionType() == constantType);
-    assert(fn->getLinkage() == linkage ||
+    // During SILGen (where the module's SIL stage is Raw), there might be
+    // mismatches between the type or linkage. This can happen, when two
+    // functions are mistakenly mapped to the same name (e.g. with @_cdecl).
+    // We want to issue a regular error in this case and not crash with an
+    // assert.
+    assert(mod.getStage() == SILStage::Raw ||
+           fn->getLoweredFunctionType() == constantType);
+    assert(mod.getStage() == SILStage::Raw || fn->getLinkage() == linkage ||
            (forDefinition == ForDefinition_t::NotForDefinition &&
             fn->getLinkage() ==
                 constant.getLinkage(ForDefinition_t::ForDefinition)));

lib/SILGen/SILGen.cpp

@@ -756,6 +756,12 @@ void SILGenModule::visitFuncDecl(FuncDecl *fd) { emitFunction(fd); }
 
 void SILGenModule::emitFunctionDefinition(SILDeclRef constant, SILFunction *f) {
 
+  if (!f->empty()) {
+    diagnose(constant.getAsRegularLocation(), diag::sil_function_redefinition,
+             f->getName());
+    return;
+  }
+
   if (constant.isForeignToNativeThunk()) {
     f->setThunk(IsThunk);
     if (constant.asForeign().isClangGenerated())

test/SILGen/diagnose_duplicate_functions.swift

@@ -0,0 +1,21 @@
+// RUN: %target-swift-emit-silgen %s -o /dev/null -verify
+
+@_silgen_name("foo")
+func a(_ x: Int) -> Int {
+  return x
+}
+
+@_silgen_name("foo")
+func b(_ x: Int) -> Int { // expected-error {{multiple definitions of symbol 'foo'}}
+  return x
+}
+
+@_cdecl("bar")
+func c(_ x: Int) -> Int {
+  return x
+}
+
+@_cdecl("bar")
+func d(_ x: Int) -> Int { // expected-error {{multiple definitions of symbol 'bar'}}
+  return x
+}

validation-test/compiler_crashers/28806-swift-silmodule-get-or-create-function.swift renamed to validation-test/compiler_crashers_fixed/28806-swift-silmodule-get-or-create-function.swift

@@ -6,5 +6,6 @@
 // See https://swift.org/CONTRIBUTORS.txt for the list of Swift project authors
 
 // REQUIRES: asserts
-// RUN: not --crash %target-swift-frontend %s -emit-ir
-@_cdecl("main")func x(){}
+// RUN: %target-swift-frontend %s -emit-ir -o /dev/null -verify
+
+@_cdecl("main")func x(){} // expected-error {{multiple definitions of symbol 'main'}}