RequirementMachine: Clean up the RequirementMachine::initWith*() methods a bit

Author: slavapestov

lib/AST/RequirementMachine/RequirementMachine.cpp

@@ -139,6 +139,9 @@ RequirementMachine::RequirementMachine(RewriteContext &ctx)
   RequirementMachineStepLimit = langOpts.RequirementMachineStepLimit;
   RequirementMachineDepthLimit = langOpts.RequirementMachineDepthLimit;
   Stats = ctx.getASTContext().Stats;
+
+  if (Stats)
+    ++Stats->getFrontendCounters().NumRequirementMachines;
 }
 
 RequirementMachine::~RequirementMachine() {}
@@ -147,19 +150,15 @@ RequirementMachine::~RequirementMachine() {}
 ///
 /// This must only be called exactly once, before any other operations are
 /// performed on this requirement machine.
+///
+/// Used by ASTContext::getOrCreateRequirementMachine().
 void RequirementMachine::initWithGenericSignature(CanGenericSignature sig) {
   Sig = sig;
   Params.append(sig.getGenericParams().begin(),
                 sig.getGenericParams().end());
 
   PrettyStackTraceGenericSignature debugStack("building rewrite system for", sig);
 
-  auto &ctx = Context.getASTContext();
-  auto *Stats = ctx.Stats;
-
-  if (Stats)
-    ++Stats->getFrontendCounters().NumRequirementMachines;
-
   FrontendStatsTracer tracer(Stats, "build-rewrite-system");
 
   if (Dump) {
@@ -189,15 +188,11 @@ void RequirementMachine::initWithGenericSignature(CanGenericSignature sig) {
 ///
 /// This must only be called exactly once, before any other operations are
 /// performed on this requirement machine.
+///
+/// Used by RequirementSignatureRequest.
 void RequirementMachine::initWithProtocols(ArrayRef<const ProtocolDecl *> protos) {
   Protos = protos;
 
-  auto &ctx = Context.getASTContext();
-  auto *Stats = ctx.Stats;
-
-  if (Stats)
-    ++Stats->getFrontendCounters().NumRequirementMachines;
-
   FrontendStatsTracer tracer(Stats, "build-rewrite-system");
 
   if (Dump) {
@@ -225,18 +220,17 @@ void RequirementMachine::initWithProtocols(ArrayRef<const ProtocolDecl *> protos
 }
 
 /// Build a requirement machine from a set of generic parameters and
-/// (possibly non-canonical or non-minimal) structural requirements.
+/// (possibly non-canonical or non-minimal) abstract requirements.
+///
+/// This must only be called exactly once, before any other operations are
+/// performed on this requirement machine.
+///
+/// Used by AbstractGenericSignatureRequest.
 void RequirementMachine::initWithAbstractRequirements(
     ArrayRef<GenericTypeParamType *> genericParams,
     ArrayRef<Requirement> requirements) {
   Params.append(genericParams.begin(), genericParams.end());
 
-  auto &ctx = Context.getASTContext();
-  auto *Stats = ctx.Stats;
-
-  if (Stats)
-    ++Stats->getFrontendCounters().NumRequirementMachines;
-
   FrontendStatsTracer tracer(Stats, "build-rewrite-system");
 
   if (Dump) {