Merge pull request #39931 from gottesmm/pr-57f4f1ba982c2b00e79684744768c9241be4f4c5

[moveOnly] Simplify some code as per DougG's review in a589b4a

Author: gottesmm

lib/Sema/TypeCheckAttr.cpp

@@ -285,17 +285,15 @@ void AttributeChecker::visitNoImplicitCopyAttr(NoImplicitCopyAttr *attr) {
     return;
   }
 
-  if (vd->hasStorage()) {
-    // We do not support fields of nominal types now.
-    if (isa<NominalTypeDecl>(dc)) {
-      auto error = diag::noimplicitcopy_attr_valid_only_on_local_let;
-      diagnoseAndRemoveAttr(attr, error);
-      return;
-    }
+  // We only support local lets.
+  if (!dc->isLocalContext()) {
+    auto error = diag::noimplicitcopy_attr_valid_only_on_local_let;
+    diagnoseAndRemoveAttr(attr, error);
+    return;
   }
 
-  // We do not support static or global vars either yet.
-  if (dc->isModuleScopeContext() || (dc->isTypeContext() && vd->isStatic())) {
+  // We do not support static vars either yet.
+  if (dc->isTypeContext() && vd->isStatic()) {
     auto error = diag::noimplicitcopy_attr_valid_only_on_local_let;
     diagnoseAndRemoveAttr(attr, error);
     return;