Merge pull request #36697 from slavapestov/unsubstitutable-sil-function-type

AST: Skip requirement checks in IsBindableVisitor::visitBoundGenericType() if substituted type is an interface type

Author: slavapestov

lib/AST/Type.cpp

@@ -1834,9 +1834,6 @@ class IsBindableVisitor
       if (nom->getDecl() != substNom->getDecl())
         return CanType();
 
-      if (nom->getDecl()->isInvalid())
-        return CanType();
-      
       // Same decl should always either have or not have a parent.
       assert((bool)nom->getParent() == (bool)substNom->getParent());
 
@@ -2078,8 +2075,6 @@ class IsBindableVisitor
       return CanType();
 
     auto *decl = bgt->getDecl();
-    if (decl->isInvalid())
-      return CanType();
 
     auto *moduleDecl = decl->getParentModule();
     auto origSubMap = bgt->getContextSubstitutionMap(
@@ -2139,6 +2134,12 @@ class IsBindableVisitor
       if (req.getKind() != RequirementKind::Conformance) continue;
 
       auto canTy = req.getFirstType()->getCanonicalType();
+
+      // If the substituted type is an interface type, we can't verify the
+      // generic requirements.
+      if (canTy.subst(substSubMap)->isTypeParameter())
+        continue;
+
       auto *proto = req.getProtocolDecl();
       auto origConf = origSubMap.lookupConformance(canTy, proto);
       auto substConf = substSubMap.lookupConformance(canTy, proto);

validation-test/compiler_crashers_2/sr13849.swift renamed to validation-test/compiler_crashers_2_fixed/sr13849.swift

@@ -1,4 +1,4 @@
-// RUN: not --crash %target-swift-frontend -emit-ir %s
+// RUN: %target-swift-frontend -emit-ir %s
 
 public protocol Prot {
     associatedtype T