[SIL] Distributed: Remove logic related to ad-hoc requirements from SILFunction

xedin · xedin · commit 1909b1237069 · 2024-02-12T14:26:30.000-08:00
Ad-hoc requirements are now obsolete by making `remoteCall`,
`record{Argument, ReturnType}`, `decodeNextArgument` protocols
requirements and injecting witness tables for `SerializationRequirement`
conformances during IRGen.
diff --git a/include/swift/SIL/SILFunction.h b/include/swift/SIL/SILFunction.h
@@ -264,17 +264,6 @@ class SILFunction
   /// @_dynamicReplacement(for:) function.
   SILFunction *ReplacedFunction = nullptr;
 
-  /// This SILFunction REFerences an ad-hoc protocol requirement witness in
-  /// order to keep it alive, such that it main be obtained in IRGen. Without
-  /// this explicit reference, the witness would seem not-used, and not be
-  /// accessible for IRGen.
-  ///
-  /// Specifically, one such case is the DistributedTargetInvocationDecoder's
-  /// 'decodeNextArgument' which must be retained, as it is only used from IRGen
-  /// and such, appears as-if unused in SIL and would get optimized away.
-  // TODO: Consider making this a general "references adhoc functions" and make it an array?
-  SILFunction *RefAdHocRequirementFunction = nullptr;
-
   Identifier ObjCReplacementFor;
 
   /// The head of a single-linked list of currently alive BasicBlockBitfield.
@@ -596,27 +585,6 @@ class SILFunction
     ReplacedFunction = nullptr;
   }
 
-  SILFunction *getReferencedAdHocRequirementWitnessFunction() const {
-    return RefAdHocRequirementFunction;
-  }
-  // Marks that this `SILFunction` uses the passed in ad-hoc protocol
-  // requirement witness `f` and therefore must retain it explicitly,
-  // otherwise we might not be able to get a reference to it.
-  void setReferencedAdHocRequirementWitnessFunction(SILFunction *f) {
-    assert(RefAdHocRequirementFunction == nullptr && "already set");
-
-    if (f == nullptr)
-      return;
-    RefAdHocRequirementFunction = f;
-    RefAdHocRequirementFunction->incrementRefCount();
-  }
-  void dropReferencedAdHocRequirementWitnessFunction() {
-    if (!RefAdHocRequirementFunction)
-      return;
-    RefAdHocRequirementFunction->decrementRefCount();
-    RefAdHocRequirementFunction = nullptr;
-  }
-
   bool hasObjCReplacement() const {
     return !ObjCReplacementFor.empty();
   }
diff --git a/lib/SIL/IR/SILFunction.cpp b/lib/SIL/IR/SILFunction.cpp
@@ -278,7 +278,6 @@ void SILFunction::createSnapshot(int id) {
   newSnapshot->DeclCtxt = DeclCtxt;
   newSnapshot->Profiler = Profiler;
   newSnapshot->ReplacedFunction = ReplacedFunction;
-  newSnapshot->RefAdHocRequirementFunction = RefAdHocRequirementFunction;
   newSnapshot->ObjCReplacementFor = ObjCReplacementFor;
   newSnapshot->SemanticsAttrSet = SemanticsAttrSet;
   newSnapshot->SpecializeAttrSet = SpecializeAttrSet;
diff --git a/lib/SIL/IR/SILFunctionBuilder.cpp b/lib/SIL/IR/SILFunctionBuilder.cpp
@@ -274,15 +274,6 @@ void SILFunctionBuilder::addFunctionAttributes(
 
       F->setDynamicallyReplacedFunction(replacedFunc);
     }
-  } else if (constant.isDistributedThunk()) {
-    auto decodeFuncDecl =
-            getAssociatedDistributedInvocationDecoderDecodeNextArgumentFunction(
-                decl);
-    assert(decodeFuncDecl && "decodeNextArgument function not found!");
-
-    auto decodeRef = SILDeclRef(decodeFuncDecl);
-    auto *adHocFunc = getOrCreateDeclaration(decodeFuncDecl, decodeRef);
-    F->setReferencedAdHocRequirementWitnessFunction(adHocFunc);
   }
 }
 
diff --git a/lib/SIL/IR/SILModule.cpp b/lib/SIL/IR/SILModule.cpp
@@ -154,7 +154,6 @@ SILModule::~SILModule() {
   for (SILFunction &F : *this) {
     F.dropAllReferences();
     F.dropDynamicallyReplacedFunction();
-    F.dropReferencedAdHocRequirementWitnessFunction();
     F.clearSpecializeAttrs();
   }
 
@@ -492,7 +491,6 @@ void SILModule::eraseFunction(SILFunction *F) {
   // (References are not needed anymore.)
   F->clear();
   F->dropDynamicallyReplacedFunction();
-  F->dropReferencedAdHocRequirementWitnessFunction();
   // Drop references for any _specialize(target:) functions.
   F->clearSpecializeAttrs();
 }
diff --git a/lib/SIL/IR/SILPrinter.cpp b/lib/SIL/IR/SILPrinter.cpp
@@ -3394,12 +3394,6 @@ void SILFunction::print(SILPrintContext &PrintCtx) const {
     OS << "\"] ";
   }
 
-  if (auto *usedFunc = getReferencedAdHocRequirementWitnessFunction()) {
-    OS << "[ref_adhoc_requirement_witness \"";
-    OS << usedFunc->getName();
-    OS << "\"] ";
-  }
-
   if (hasObjCReplacement()) {
     OS << "[objc_replacement_for \"";
     OS << getObjCReplacement().str();
diff --git a/lib/SIL/Parser/ParseSIL.cpp b/lib/SIL/Parser/ParseSIL.cpp
@@ -675,7 +675,7 @@ static bool parseDeclSILOptional(
     UseStackForPackMetadata_t *useStackForPackMetadata,
     bool *hasUnsafeNonEscapableResult, IsExactSelfClass_t *isExactSelfClass,
     SILFunction **dynamicallyReplacedFunction,
-    SILFunction **usedAdHocRequirementWitness, Identifier *objCReplacementFor,
+    Identifier *objCReplacementFor,
     SILFunction::Purpose *specialPurpose, Inline_t *inlineStrategy,
     OptimizationMode *optimizationMode, PerformanceConstraints *perfConstraints,
     bool *isPerformanceConstraint,
@@ -825,26 +825,6 @@ static bool parseDeclSILOptional(
       *dynamicallyReplacedFunction = Func;
       SP.P.consumeToken(tok::string_literal);
 
-      SP.P.parseToken(tok::r_square, diag::expected_in_attribute_list);
-      continue;
-    } else if (usedAdHocRequirementWitness && SP.P.Tok.getText() == "ref_adhoc_requirement_witness") {
-      SP.P.consumeToken(tok::identifier);
-      if (SP.P.Tok.getKind() != tok::string_literal) {
-        SP.P.diagnose(SP.P.Tok, diag::expected_in_attribute_list);
-        return true;
-      }
-      // Drop the double quotes.
-      StringRef witnessFunc = SP.P.Tok.getText().drop_front().drop_back();
-      SILFunction *Func = M.lookUpFunction(witnessFunc.str());
-      if (!Func) {
-        Identifier Id = SP.P.Context.getIdentifier(witnessFunc);
-        SP.P.diagnose(SP.P.Tok, diag::sil_adhoc_requirement_witness_func_not_found,
-                      Id);
-        return true;
-      }
-      *usedAdHocRequirementWitness = Func;
-      SP.P.consumeToken(tok::string_literal);
-
       SP.P.parseToken(tok::r_square, diag::expected_in_attribute_list);
       continue;
     } else if (objCReplacementFor &&
@@ -7061,7 +7041,6 @@ bool SILParserState::parseDeclSIL(Parser &P) {
   ValueDecl *ClangDecl = nullptr;
   EffectsKind MRK = EffectsKind::Unspecified;
   SILFunction *DynamicallyReplacedFunction = nullptr;
-  SILFunction *AdHocWitnessFunction = nullptr;
   Identifier objCReplacementFor;
   if (parseSILLinkage(FnLinkage, P) ||
       parseDeclSILOptional(
@@ -7070,7 +7049,7 @@ bool SILParserState::parseDeclSIL(Parser &P) {
           &isRuntimeAccessible, &forceEnableLexicalLifetimes,
           &useStackForPackMetadata, &hasUnsafeNonEscapableResult,
           &isExactSelfClass, &DynamicallyReplacedFunction,
-          &AdHocWitnessFunction, &objCReplacementFor, &specialPurpose,
+          &objCReplacementFor, &specialPurpose,
           &inlineStrategy, &optimizationMode, &perfConstr,
           &isPerformanceConstraint, &markedAsUsed,
           &section, nullptr, &isWeakImported, &needStackProtection,
@@ -7116,8 +7095,6 @@ bool SILParserState::parseDeclSIL(Parser &P) {
     FunctionState.F->setIsExactSelfClass(isExactSelfClass);
     FunctionState.F->setDynamicallyReplacedFunction(
         DynamicallyReplacedFunction);
-    FunctionState.F->setReferencedAdHocRequirementWitnessFunction(
-        AdHocWitnessFunction);
     if (!objCReplacementFor.empty())
       FunctionState.F->setObjCReplacement(objCReplacementFor);
     FunctionState.F->setSpecialPurpose(specialPurpose);
@@ -7327,7 +7304,7 @@ bool SILParserState::parseSILGlobal(Parser &P) {
                            nullptr, nullptr, nullptr, nullptr, nullptr, nullptr,
                            nullptr, nullptr, nullptr, nullptr, nullptr, nullptr,
                            nullptr,
-                           nullptr, nullptr, nullptr, nullptr, nullptr, &isLet,
+                           nullptr, nullptr, nullptr, nullptr, &isLet,
                            nullptr, nullptr, nullptr, nullptr, nullptr, nullptr,
                            nullptr, nullptr, State, M) ||
       P.parseToken(tok::at_sign, diag::expected_sil_value_name) ||
@@ -7381,7 +7358,7 @@ bool SILParserState::parseSILProperty(Parser &P) {
                            nullptr, nullptr, nullptr, nullptr, nullptr, nullptr,
                            nullptr, nullptr, nullptr, nullptr, nullptr, nullptr,
                            nullptr, nullptr, nullptr, nullptr, nullptr, nullptr,
-                           nullptr, nullptr, nullptr, SP, M))
+                           nullptr, nullptr, SP, M))
     return true;
   
   ValueDecl *VD;
@@ -7451,7 +7428,7 @@ bool SILParserState::parseSILVTable(Parser &P) {
                            nullptr, nullptr, nullptr, nullptr, nullptr, nullptr,
                            nullptr, nullptr, nullptr, nullptr, nullptr, nullptr,
                            nullptr, nullptr, nullptr, nullptr, nullptr, nullptr,
-                           nullptr, nullptr, nullptr, VTableState, M))
+                           nullptr, nullptr, VTableState, M))
     return true;
 
   // Parse the class name.
@@ -7562,7 +7539,7 @@ bool SILParserState::parseSILMoveOnlyDeinit(Parser &parser) {
                            nullptr, nullptr, nullptr, nullptr, nullptr, nullptr,
                            nullptr, nullptr, nullptr, nullptr, nullptr, nullptr,
                            nullptr, nullptr, nullptr, nullptr, nullptr, nullptr,
-                           nullptr, nullptr, nullptr, moveOnlyDeinitTableState, M))
+                           nullptr, nullptr, moveOnlyDeinitTableState, M))
     return true;
 
   // Parse the class name.
@@ -8049,7 +8026,7 @@ bool SILParserState::parseSILWitnessTable(Parser &P) {
                            nullptr, nullptr, nullptr, nullptr, nullptr, nullptr,
                            nullptr, nullptr, nullptr, nullptr, nullptr, nullptr,
                            nullptr, nullptr, nullptr, nullptr, nullptr, nullptr,
-                           nullptr, nullptr, nullptr, WitnessState, M))
+                           nullptr, nullptr, WitnessState, M))
     return true;
 
   // Parse the protocol conformance.
diff --git a/lib/SILOptimizer/Analysis/CallerAnalysis.cpp b/lib/SILOptimizer/Analysis/CallerAnalysis.cpp
@@ -35,7 +35,6 @@ CallerAnalysis::FunctionInfo::FunctionInfo(SILFunction *f)
       // final/visibility/etc.
       mayHaveIndirectCallers(
           f->getDynamicallyReplacedFunction() ||
-          f->getReferencedAdHocRequirementWitnessFunction() ||
           canBeCalledIndirectly(f->getRepresentation())),
       mayHaveExternalCallers(f->isPossiblyUsedExternally() ||
                              f->isAvailableExternally()) {}
diff --git a/lib/SILOptimizer/FunctionSignatureTransforms/FunctionSignatureOpts.cpp b/lib/SILOptimizer/FunctionSignatureTransforms/FunctionSignatureOpts.cpp
@@ -668,7 +668,6 @@ bool FunctionSignatureTransform::run(bool hasCaller) {
   hasCaller |= FSOOptimizeIfNotCalled;
 
   if (!hasCaller && (F->getDynamicallyReplacedFunction() ||
-                     F->getReferencedAdHocRequirementWitnessFunction() ||
                      canBeCalledIndirectly(F->getRepresentation()))) {
     LLVM_DEBUG(llvm::dbgs() << "  function has no caller -> abort\n");
     return false;
diff --git a/lib/SILOptimizer/IPO/DeadFunctionElimination.cpp b/lib/SILOptimizer/IPO/DeadFunctionElimination.cpp
@@ -110,9 +110,6 @@ class DeadFunctionAndGlobalElimination {
     if (F->isDynamicallyReplaceable())
       return true;
 
-    if (F->getReferencedAdHocRequirementWitnessFunction())
-      return true;
-
     // Don't remove pre-specialized functions. We need to preserver the
     // pre-specialization specifications from other modules.
     if (F->hasPrespecialization())
@@ -343,9 +340,6 @@ class DeadFunctionAndGlobalElimination {
     if (auto *replacedFn = F->getDynamicallyReplacedFunction())
       ensureAlive(replacedFn);
 
-    if (auto *adHocWitness = F->getReferencedAdHocRequirementWitnessFunction())
-      ensureAlive(adHocWitness);
-
     // First scan all instructions of the function.
     for (SILBasicBlock &BB : *F) {
       for (SILInstruction &I : BB) {
diff --git a/lib/Serialization/DeserializeSIL.cpp b/lib/Serialization/DeserializeSIL.cpp
@@ -538,7 +538,6 @@ SILDeserializer::readSILFunctionChecked(DeclID FID, SILFunction *existingFn,
   ModuleID parentModuleID;
   TypeID funcTyID;
   IdentifierID replacedFunctionID;
-  IdentifierID usedAdHocWitnessFunctionID;
   GenericSignatureID genericSigID;
   unsigned rawLinkage, isTransparent, isSerialized, isThunk,
       isWithoutActuallyEscapingThunk, specialPurpose, inlineStrategy,
@@ -554,7 +553,7 @@ SILDeserializer::readSILFunctionChecked(DeclID FID, SILFunction *existingFn,
       numAttrs, hasQualifiedOwnership, isWeakImported,
       LIST_VER_TUPLE_PIECES(available), isDynamic, isExactSelfClass,
       isDistributed, isRuntimeAccessible, forceEnableLexicalLifetimes, funcTyID,
-      replacedFunctionID, usedAdHocWitnessFunctionID, genericSigID,
+      replacedFunctionID, genericSigID,
       clangNodeOwnerID, parentModuleID, SemanticsIDs);
 
   if (funcTyID == 0)
@@ -583,13 +582,6 @@ SILDeserializer::readSILFunctionChecked(DeclID FID, SILFunction *existingFn,
     replacedObjectiveCFunc = MF->getIdentifier(replacedFunctionID);
   }
 
-  SILFunction *usedAdHocWitnessFunction = nullptr;
-  if (usedAdHocWitnessFunctionID) {
-    auto usedAdHocWitnessFunctionStr =
-        MF->getIdentifier(usedAdHocWitnessFunctionID).str();
-    usedAdHocWitnessFunction = getFuncForReference(usedAdHocWitnessFunctionStr);
-  }
-
   auto linkageOpt = fromStableSILLinkage(rawLinkage);
   if (!linkageOpt) {
     LLVM_DEBUG(llvm::dbgs() << "invalid linkage code " << rawLinkage
@@ -708,8 +700,6 @@ SILDeserializer::readSILFunctionChecked(DeclID FID, SILFunction *existingFn,
       fn->setDynamicallyReplacedFunction(replacedFunction);
     if (!replacedObjectiveCFunc.empty())
       fn->setObjCReplacement(replacedObjectiveCFunc);
-    if (usedAdHocWitnessFunction)
-      fn->setReferencedAdHocRequirementWitnessFunction(usedAdHocWitnessFunction);
     if (clangNodeOwner)
       fn->setClangNodeOwner(clangNodeOwner);
     for (auto ID : SemanticsIDs) {
@@ -3385,7 +3375,6 @@ bool SILDeserializer::hasSILFunction(StringRef Name,
   ModuleID parentModuleID;
   TypeID funcTyID;
   IdentifierID replacedFunctionID;
-  IdentifierID usedAdHocWitnessFunctionID;
   GenericSignatureID genericSigID;
   unsigned rawLinkage, isTransparent, isSerialized, isThunk,
       isWithoutActuallyEscapingThunk, isGlobal, inlineStrategy,
@@ -3401,7 +3390,7 @@ bool SILDeserializer::hasSILFunction(StringRef Name,
       numSpecAttrs, hasQualifiedOwnership, isWeakImported,
       LIST_VER_TUPLE_PIECES(available), isDynamic, isExactSelfClass,
       isDistributed, isRuntimeAccessible, forceEnableLexicalLifetimes, funcTyID,
-      replacedFunctionID, usedAdHocWitnessFunctionID, genericSigID,
+      replacedFunctionID, genericSigID,
       clangOwnerID, parentModuleID, SemanticsIDs);
   auto linkage = fromStableSILLinkage(rawLinkage);
   if (!linkage) {
diff --git a/lib/Serialization/ModuleFormat.h b/lib/Serialization/ModuleFormat.h
@@ -58,7 +58,7 @@ const uint16_t SWIFTMODULE_VERSION_MAJOR = 0;
 /// describe what change you made. The content of this comment isn't important;
 /// it just ensures a conflict if two people change the module format.
 /// Don't worry about adhering to the 80-column limit for this line.
-const uint16_t SWIFTMODULE_VERSION_MINOR = 850; // MarkDependenceKind
+const uint16_t SWIFTMODULE_VERSION_MINOR = 851; // Drop ad-hoc requirement refs from SILFunctionLayout
 
 /// A standard hash seed used for all string hashes in a serialized module.
 ///
diff --git a/lib/Serialization/SILFormat.h b/lib/Serialization/SILFormat.h
@@ -312,7 +312,6 @@ namespace sil_block {
                      BCFixed<1>,  // are lexical lifetimes force-enabled
                      TypeIDField, // SILFunctionType
                      DeclIDField,  // SILFunction name or 0 (replaced function)
-                     DeclIDField,  // SILFunction name or 0 (used ad-hoc requirement witness function)
                      GenericSignatureIDField,
                      DeclIDField, // ClangNode owner
                      ModuleIDField, // Parent ModuleDecl *
diff --git a/lib/Serialization/SerializeSIL.cpp b/lib/Serialization/SerializeSIL.cpp
@@ -483,12 +483,6 @@ void SILSerializer::writeSILFunction(const SILFunction &F, bool DeclOnly) {
         S.addUniquedStringRef(F.getObjCReplacement().str());
   }
 
-  IdentifierID usedAdHocWitnessFunctionID = 0;
-  if (auto *fun = F.getReferencedAdHocRequirementWitnessFunction()) {
-    addReferencedSILFunction(fun, true);
-    usedAdHocWitnessFunctionID = S.addUniquedStringRef(fun->getName());
-  }
-
   unsigned numAttrs = NoBody ? 0 : F.getSpecializeAttrs().size();
 
   auto resilience = F.getModule().getSwiftModule()->getResilienceStrategy();
@@ -522,7 +516,7 @@ void SILSerializer::writeSILFunction(const SILFunction &F, bool DeclOnly) {
       (unsigned)F.isExactSelfClass(), (unsigned)F.isDistributed(),
       (unsigned)F.isRuntimeAccessible(),
       (unsigned)F.forceEnableLexicalLifetimes(), FnID, replacedFunctionID,
-      usedAdHocWitnessFunctionID, genericSigID, clangNodeOwnerID,
+      genericSigID, clangNodeOwnerID,
       parentModuleID, SemanticsIDs);
 
   F.visitArgEffects(
diff --git a/test/Distributed/SIL/distributed_thunk.swift b/test/Distributed/SIL/distributed_thunk.swift
@@ -9,7 +9,7 @@ distributed actor DA {
 }
 
 extension DA {
-  // CHECK-LABEL: sil hidden [thunk] [distributed] [ref_adhoc_requirement_witness "$s11Distributed29LocalTestingInvocationDecoderC18decodeNextArgumentxyKSeRzSERzlF"] [ossa] @$s17distributed_thunk2DAC1fyyYaKFTE : $@convention(method) @async (@guaranteed DA) -> @error any Error {
+  // CHECK-LABEL: sil hidden [thunk] [distributed] [ossa] @$s17distributed_thunk2DAC1fyyYaKFTE : $@convention(method) @async (@guaranteed DA) -> @error any Error {
   // CHECK: function_ref @swift_distributed_actor_is_remote
 
   // Call the actor function
@@ -65,7 +65,7 @@ protocol Server2: DistributedActor {
 }
 
 extension Server2 where ActorSystem == LocalTestingDistributedActorSystem {
-  // CHECK-LABEL: sil hidden [thunk] [distributed] [ref_adhoc_requirement_witness "$s11Distributed29LocalTestingInvocationDecoderC18decodeNextArgumentxyKSeRzSERzlF"] [ossa] @$s17distributed_thunk7Server2PAA11Distributed012LocalTestingD11ActorSystemC0gH0RtzrlE8sayHelloyyYaKFTE
+  // CHECK-LABEL: sil hidden [thunk] [distributed] [ossa] @$s17distributed_thunk7Server2PAA11Distributed012LocalTestingD11ActorSystemC0gH0RtzrlE8sayHelloyyYaKFTE
   // CHECK-NOT: return
   // CHECK: function_ref @swift_distributed_actor_is_remote
   distributed func sayHello() { /* default impl */ }

Original file line number	Diff line number	Diff line change
`@@ -274,15 +274,6 @@ void SILFunctionBuilder::addFunctionAttributes(`
`274`	`274`
`275`	`275`	`F->setDynamicallyReplacedFunction(replacedFunc);`
`276`	`276`	`}`
`277`		`- } else if (constant.isDistributedThunk()) {`
`278`		`- auto decodeFuncDecl =`
`279`		`- getAssociatedDistributedInvocationDecoderDecodeNextArgumentFunction(`
`280`		`- decl);`
`281`		`- assert(decodeFuncDecl && "decodeNextArgument function not found!");`
`282`		`-`
`283`		`- auto decodeRef = SILDeclRef(decodeFuncDecl);`
`284`		`- auto *adHocFunc = getOrCreateDeclaration(decodeFuncDecl, decodeRef);`
`285`		`- F->setReferencedAdHocRequirementWitnessFunction(adHocFunc);`
`286`	`277`	`}`
`287`	`278`	`}`
`288`	`279`
Original file line number	Diff line number	Diff line change
`@@ -154,7 +154,6 @@ SILModule::~SILModule() {`
`154`	`154`	`for (SILFunction &F : *this) {`
`155`	`155`	`F.dropAllReferences();`
`156`	`156`	`F.dropDynamicallyReplacedFunction();`
`157`		`- F.dropReferencedAdHocRequirementWitnessFunction();`
`158`	`157`	`F.clearSpecializeAttrs();`
`159`	`158`	`}`
`160`	`159`
`@@ -492,7 +491,6 @@ void SILModule::eraseFunction(SILFunction *F) {`
`492`	`491`	`// (References are not needed anymore.)`
`493`	`492`	`F->clear();`
`494`	`493`	`F->dropDynamicallyReplacedFunction();`
`495`		`- F->dropReferencedAdHocRequirementWitnessFunction();`
`496`	`494`	`// Drop references for any _specialize(target:) functions.`
`497`	`495`	`F->clearSpecializeAttrs();`
`498`	`496`	`}`