Merge pull request #42033 from DougGregor/validate-global-actor-attr

Make sure we evaluate the a global actor annotation on an extension.

Author: DougGregor

lib/Sema/TypeCheckAttr.cpp

@@ -3283,8 +3283,18 @@ void AttributeChecker::visitCustomAttr(CustomAttr *attr) {
   // retrieval request perform checking for us.
   if (nominal->isGlobalActor()) {
     (void)D->getGlobalActorAttr();
-    if (auto value = dyn_cast<ValueDecl>(D))
+    if (auto value = dyn_cast<ValueDecl>(D)) {
       (void)getActorIsolation(value);
+    } else {
+      // Make sure we evaluate the global actor type.
+      auto dc = D->getInnermostDeclContext();
+      (void)evaluateOrDefault(
+          Ctx.evaluator,
+          CustomAttrTypeRequest{
+            attr, dc, CustomAttrTypeKind::GlobalActor},
+          Type());
+    }
+
     return;
   }
 

test/Serialization/Inputs/actor_bar.swift

@@ -1 +1,6 @@
 public actor Bar {}
+
+public class SomewhatOnMainActor { }
+
+@MainActor
+extension SomewhatOnMainActor { }