Merge pull request #77034 from slavapestov/fix-rdar117815191

IRGen: Fix emission of calls to opaque return type metadata access function with packs

Author: slavapestov

lib/IRGen/GenArchetype.cpp

@@ -453,12 +453,16 @@ withOpaqueTypeGenericArgs(IRGenFunction &IGF,
     SmallVector<llvm::Value *, 4> args;
     SmallVector<llvm::Type *, 4> types;
 
+    // We need to pass onHeapPacks=true because the runtime demangler
+    // expects to differentiate on-heap packs from non-pack types by
+    // checking the least significant bit of the metadata pointer.
     enumerateGenericSignatureRequirements(
         opaqueDecl->getGenericSignature().getCanonicalSignature(),
         [&](GenericRequirement reqt) {
           auto arg = emitGenericRequirementFromSubstitutions(
               IGF, reqt, MetadataState::Abstract,
-              archetype->getSubstitutions());
+              archetype->getSubstitutions(),
+              /*onHeapPacks=*/true);
           args.push_back(arg);
           types.push_back(args.back()->getType());
         });

test/Interpreter/Inputs/variadic_generic_opaque_type_other.swift

@@ -0,0 +1,22 @@
+public protocol P {}
+
+extension Int: P {}
+extension String: P {}
+extension Bool: P {}
+extension Double: P {}
+
+public protocol Q {}
+
+public func f1<each T: P>(_ t: repeat each T) -> some Any {
+  return (repeat each t)
+}
+
+public struct G2<T>: Q {}
+public func f2<each T: P>(_ t: repeat each T) -> some Q {
+  return G2<(repeat each T)>()
+}
+
+public struct G3<each T>: Q {}
+public func f3<each T: P>(_ t: repeat each T) -> some Q {
+  return G3<repeat each T>()
+}

test/Interpreter/variadic_generic_opaque_type.swift

@@ -0,0 +1,44 @@
+// RUN: %empty-directory(%t)
+//
+// RUN: %target-build-swift-dylib(%t/%target-library-name(variadic_generic_opaque_type_other)) %S/Inputs/variadic_generic_opaque_type_other.swift -emit-module -emit-module-path %t/variadic_generic_opaque_type_other.swiftmodule -module-name variadic_generic_opaque_type_other -Xfrontend -disable-availability-checking -enable-library-evolution
+// RUN: %target-codesign %t/%target-library-name(variadic_generic_opaque_type_other)
+//
+// RUN: %target-build-swift %s -I %t -o %t/main.out -L %t %target-rpath(%t) -lvariadic_generic_opaque_type_other
+// RUN: %target-codesign %t/main.out
+//
+// RUN: %target-run %t/main.out %t/%target-library-name(variadic_generic_opaque_type_other)
+
+// REQUIRES: executable_test
+
+import variadic_generic_opaque_type_other
+import StdlibUnittest
+
+var opaque = TestSuite("VariadicGenericOpaqueTypes")
+
+func getType<T>(_: T) -> Any.Type {
+  return T.self
+}
+
+opaque.test("Opaque1") {
+  expectEqual((Int, String).self, getType(f1(1, "hi")))
+  expectEqual(G2<(Bool, String)>.self, getType(f2(false, "hi")))
+  expectEqual(G3<Bool, Double>.self, getType(f3(false, 3.0)))
+}
+
+func g1<each T: P>(_ t: repeat each T) -> Any.Type {
+  return getType(f1(repeat each t))
+}
+func g2<each T: P>(_ t: repeat each T) -> Any.Type {
+  return getType(f2(repeat each t))
+}
+func g3<each T: P>(_ t: repeat each T) -> Any.Type {
+  return getType(f3(repeat each t))
+}
+
+opaque.test("Opaque2") {
+  expectEqual((Int, String).self, g1(1, "hi"))
+  expectEqual(G2<(Bool, String)>.self, g2(false, "hi"))
+  expectEqual(G3<Bool, Double>.self, g3(false, 3.0))
+}
+
+runAllTests()