[ConstraintSystem] Fail closure resolution if one of the parameters has invalid property wrapper

xedin · xedin · commit 0e4d16d5857f · 2022-04-28T18:02:19.000-07:00
diff --git a/lib/Sema/CSSimplify.cpp b/lib/Sema/CSSimplify.cpp
@@ -9914,8 +9914,9 @@ bool ConstraintSystem::resolveClosure(TypeVariableType *typeVar,
       }
 
       if (!paramDecl->getName().hasDollarPrefix()) {
-        generateWrappedPropertyTypeConstraints(paramDecl, backingType,
-                                               param.getParameterType());
+        if (generateWrappedPropertyTypeConstraints(paramDecl, backingType,
+                                                   param.getParameterType()))
+          return false;
       }
 
       auto result = applyPropertyWrapperToParameter(backingType, param.getParameterType(),

Original file line number	Diff line number	Diff line change
`@@ -9914,8 +9914,9 @@ bool ConstraintSystem::resolveClosure(TypeVariableType *typeVar,`
`9914`	`9914`	`}`
`9915`	`9915`
`9916`	`9916`	`if (!paramDecl->getName().hasDollarPrefix()) {`
`9917`		`- generateWrappedPropertyTypeConstraints(paramDecl, backingType,`
`9918`		`- param.getParameterType());`
	`9917`	`+ if (generateWrappedPropertyTypeConstraints(paramDecl, backingType,`
	`9918`	`+ param.getParameterType()))`
	`9919`	`+ return false;`
`9919`	`9920`	`}`
`9920`	`9921`
`9921`	`9922`	`auto result = applyPropertyWrapperToParameter(backingType, param.getParameterType(),`