Merge pull request #42074 from ktoso/wip-avoid-double-typechecking

[Distributed] avoid double typechecking dist func decl

Author: ktoso

lib/Sema/CodeSynthesisDistributedActor.cpp

@@ -699,8 +699,7 @@ FuncDecl *GetDistributedThunkRequest::evaluate(
   // Force type-checking the original function, so we can avoid synthesizing
   // the thunks (which would have many of the same errors, if they are caused
   // by a bad source function signature, e.g. missing conformances etc).
-  (void) TypeChecker::typeCheckDecl(distributedTarget);
-  if (distributedTarget->getDiags().hadAnyError()) {
+  if (distributedTarget->getInterfaceType()->hasError()) {
     return nullptr;
   }
 

test/Distributed/distributed_actor_isolation.swift

@@ -1,6 +1,6 @@
 // RUN: %empty-directory(%t)
 // RUN: %target-swift-frontend-emit-module -emit-module-path %t/FakeDistributedActorSystems.swiftmodule -module-name FakeDistributedActorSystems -disable-availability-checking %S/Inputs/FakeDistributedActorSystems.swift
-// RUN: %target-swift-frontend -typecheck -verify -disable-availability-checking -I %t 2>&1 %s
+// RUN: %target-swift-frontend -typecheck -verify -verify-ignore-unknown -disable-availability-checking -I %t 2>&1 %s
 // REQUIRES: concurrency
 // REQUIRES: distributed
 
@@ -46,7 +46,6 @@ distributed actor DistributedActor_1 {
   distributed class func distributedClass() {}
   // expected-error@-1{{class methods are only allowed within classes; use 'static' to declare a static method}}
   // expected-error@-2{{'distributed' method cannot be 'static'}}
-  // expected-error@-3{{class methods are only allowed within classes; use 'static' to declare a static method}}
 
   func hello() {} // expected-note{{distributed actor-isolated instance method 'hello()' declared here}}
   func helloAsync() async {} // expected-note{{distributed actor-isolated instance method 'helloAsync()' declared here}}