Merge pull request #77452 from aschwaighofer/enable_async_metadata

IRGen: Enable EmitAsyncFramePushPopMetadata per default

Author: aschwaighofer

include/swift/AST/IRGenOptions.h

@@ -590,7 +590,7 @@ class IRGenOptions {
         DisableReadonlyStaticObjects(false), CollocatedMetadataFunctions(false),
         ColocateTypeDescriptors(true), UseRelativeProtocolWitnessTables(false),
         UseFragileResilientProtocolWitnesses(false), EnableHotColdSplit(false),
-        EmitAsyncFramePushPopMetadata(false), EmitYieldOnce2AsYieldOnce(true),
+        EmitAsyncFramePushPopMetadata(true), EmitYieldOnce2AsYieldOnce(true),
         AsyncFramePointerAll(false), UseProfilingMarkerThunks(false),
         DebugInfoForProfiling(false), CmdArgs(),
         SanitizeCoverage(llvm::SanitizerCoverageOptions()),

lib/IRGen/IRGenSIL.cpp

@@ -2605,7 +2605,8 @@ void IRGenSILFunction::emitSILFunction() {
                              LinkEntity::forSILFunction(CurSILFn),
                              getAsyncContextLayout(*this).getSize());
 
-    if (IGM.getOptions().EmitAsyncFramePushPopMetadata) {
+    if (IGM.getOptions().EmitAsyncFramePushPopMetadata &&
+        IGM.TargetInfo.OutputObjectFormat  == llvm::Triple::MachO) {
       CurFn->addFnAttr("async_entry");
       CurFn->addFnAttr(llvm::Attribute::NoInline);
     }

test/IRGen/async_frame_entry_return_metadata.swift

@@ -1,7 +1,7 @@
 // RUN: %target-swift-frontend -primary-file %s -emit-ir  -module-name async -target %target-swift-5.1-abi-triple -enable-async-frame-push-pop-metadata | %FileCheck %s --check-prefix=ENABLED
 // RUN: %target-swift-frontend -primary-file %s -emit-ir  -module-name async -target %target-swift-5.1-abi-triple -O -enable-async-frame-push-pop-metadata | %FileCheck %s --check-prefix=ENABLED
 // RUN: %target-swift-frontend -primary-file %s -emit-ir  -module-name async -target %target-swift-5.1-abi-triple -disable-async-frame-push-pop-metadata | %FileCheck %s --check-prefix=DISABLED
-// RUN: %target-swift-frontend -primary-file %s -emit-ir  -module-name async -target %target-swift-5.1-abi-triple | %FileCheck %s --check-prefix=DISABLED
+// RUN: %target-swift-frontend -primary-file %s -emit-ir  -module-name async -target %target-swift-5.1-abi-triple | %FileCheck %s --check-prefix=ENABLED
 
 // REQUIRES: OS=macosx || OS=iphoneos
 // REQUIRES: PTRSIZE=64