Merge pull request #40552 from CodaFi/a-heart-warning-story

[NFC] Clean Up Some Warnings

Author: CodaFi

include/swift/AST/PrintOptions.h

@@ -95,7 +95,6 @@ class AnyAttrKind {
     static_assert(DAK_Count < UINT_MAX, "DeclAttrKind is > 31 bits");
   }
   AnyAttrKind() : kind(TAK_Count), isType(1) {}
-  AnyAttrKind(const AnyAttrKind &) = default;
 
   /// Returns the TypeAttrKind, or TAK_Count if this is not a type attribute.
   TypeAttrKind type() const {

include/swift/Basic/SupplementaryOutputPaths.h

@@ -156,7 +156,6 @@ struct SupplementaryOutputPaths {
   std::string BitstreamOptRecordPath;
 
   SupplementaryOutputPaths() = default;
-  SupplementaryOutputPaths(const SupplementaryOutputPaths &) = default;
 
   /// Apply a given function for each existing (non-empty string) supplementary output
   void forEachSetOutput(llvm::function_ref<void(const std::string&)> fn) const {

include/swift/Parse/ParserPosition.h

@@ -31,7 +31,6 @@ class ParserPosition {
       : LS(LS), PreviousLoc(PreviousLoc) {}
 public:
   ParserPosition() = default;
-  ParserPosition &operator=(const ParserPosition &) = default;
 
   bool isValid() const { return LS.isValid(); }
 };

lib/ClangImporter/ClangImporter.cpp

@@ -2226,8 +2226,8 @@ ClangImporter::Implementation::Implementation(
       EnableClangSPI(ctx.ClangImporterOpts.EnableClangSPI),
       IsReadingBridgingPCH(false),
       CurrentVersion(ImportNameVersion::fromOptions(ctx.LangOpts)),
-      BuffersForDiagnostics(ctx.SourceMgr),
       BridgingHeaderLookupTable(new SwiftLookupTable(nullptr)),
+      BuffersForDiagnostics(ctx.SourceMgr),
       platformAvailability(ctx.LangOpts), nameImporter(),
       DisableSourceImport(ctx.ClangImporterOpts.DisableSourceImport),
       DWARFImporter(dwarfImporterDelegate) {}

lib/ClangImporter/ImportDecl.cpp

@@ -3923,12 +3923,10 @@ namespace {
       if (foreignReferenceTypePassedByRef(decl))
         return nullptr;
 
-      AbstractStorageDecl *owningStorage;
       switch (importedName.getAccessorKind()) {
       case ImportedAccessorKind::None:
       case ImportedAccessorKind::SubscriptGetter:
       case ImportedAccessorKind::SubscriptSetter:
-        owningStorage = nullptr;
         break;
 
       case ImportedAccessorKind::PropertyGetter: {

lib/Parse/ParseDecl.cpp

@@ -7096,7 +7096,7 @@ ParserResult<FuncDecl> Parser::parseDeclFunc(SourceLoc StaticLoc,
   // Create the decl for the func and add it to the parent scope.
   auto *FD = FuncDecl::create(Context, StaticLoc, StaticSpelling,
                               FuncLoc, FullName, NameLoc,
-                              /*Async=*/asyncLoc.isValid(), asyncLoc,
+                              /*Async=*/isAsync, asyncLoc,
                               /*Throws=*/throwsLoc.isValid(), throwsLoc,
                               GenericParams,
                               BodyParams, FuncRetTy,

lib/Serialization/Serialization.cpp

@@ -3288,10 +3288,6 @@ class Serializer::DeclSerializer : public DeclVisitor<DeclSerializer> {
         binding->getNumPatternEntries(),
         initContextIDs);
 
-    DeclContext *owningDC = nullptr;
-    if (binding->getDeclContext()->isTypeContext())
-      owningDC = binding->getDeclContext();
-
     for (auto entryIdx : range(binding->getNumPatternEntries())) {
       writePattern(binding->getPattern(entryIdx));
       // Ignore initializer; external clients don't need to know about it.