Merge pull request #80292 from DougGregor/recursively-remove-unsafe-inlinable

Properly recurse when removing "unsafe" from inlinable code

Author: DougGregor

lib/ASTGen/Sources/ASTGen/CompilerBuildConfiguration.swift

@@ -550,11 +550,13 @@ public func extractInlinableText(
 /// a syntax tree.
 fileprivate class RemoveUnsafeExprSyntaxRewriter: SyntaxRewriter {
   override func visit(_ node: UnsafeExprSyntax) -> ExprSyntax {
-    return node.expression.with(\.leadingTrivia, node.leadingTrivia)
+    let rewritten = super.visit(node).cast(UnsafeExprSyntax.self)
+    return rewritten.expression.with(\.leadingTrivia, node.leadingTrivia)
   }
 
   override func visit(_ node: ForStmtSyntax) -> StmtSyntax {
-    return StmtSyntax(node.with(\.unsafeKeyword, nil))
+    let rewritten = super.visit(node).cast(ForStmtSyntax.self)
+    return StmtSyntax(rewritten.with(\.unsafeKeyword, nil))
   }
 }
 

test/Unsafe/module-interface.swift

@@ -23,7 +23,9 @@ public struct SequenceWithUnsafeIterator: Sequence {
   // CHECK-NOT: unsafe
   print( unsafe getIntUnsafely())
 
-  for unsafe _ in SequenceWithUnsafeIterator() { }
+  for unsafe _ in SequenceWithUnsafeIterator() {
+    _ = unsafe getIntUnsafely()
+  }
 }
 
 // CHECK: public protocol P