[embedded] Make sure to drop all references before deleting functions and globals in DropAllSILPass

kubamracek · kubamracek · commit 05dc240471e6 · 2024-03-28T11:20:18.000-07:00
diff --git a/lib/SILOptimizer/UtilityPasses/DropAllSILPass.cpp b/lib/SILOptimizer/UtilityPasses/DropAllSILPass.cpp
@@ -30,10 +30,12 @@ class DropAllSILPass : public SILModuleTransform {
     llvm::SmallVector<SILGlobalVariable *, 16> GlobalsToErase;
 
     for (SILFunction &F : M) {
+      F.dropAllReferences();
       FunctionsToErase.push_back(&F);
     }
 
     for (SILGlobalVariable &G : M.getSILGlobals()) {
+      G.dropAllReferences();
       GlobalsToErase.push_back(&G);
     }
 

Original file line number	Diff line number	Diff line change
`@@ -30,10 +30,12 @@ class DropAllSILPass : public SILModuleTransform {`
`30`	`30`	`llvm::SmallVector<SILGlobalVariable *, 16> GlobalsToErase;`
`31`	`31`
`32`	`32`	`for (SILFunction &F : M) {`
	`33`	`+ F.dropAllReferences();`
`33`	`34`	`FunctionsToErase.push_back(&F);`
`34`	`35`	`}`
`35`	`36`
`36`	`37`	`for (SILGlobalVariable &G : M.getSILGlobals()) {`
	`38`	`+ G.dropAllReferences();`
`37`	`39`	`GlobalsToErase.push_back(&G);`
`38`	`40`	`}`
`39`	`41`