Merge pull request #40230 from CodaFi/noreturn-of-the-king

Silence Some Warnings

Author: CodaFi

lib/ClangImporter/ClangImporter.cpp

@@ -2206,8 +2206,8 @@ ClangImporter::Implementation::Implementation(
       EnableClangSPI(ctx.ClangImporterOpts.EnableClangSPI),
       IsReadingBridgingPCH(false),
       CurrentVersion(ImportNameVersion::fromOptions(ctx.LangOpts)),
-      BridgingHeaderLookupTable(new SwiftLookupTable(nullptr)),
       BuffersForDiagnostics(ctx.SourceMgr),
+      BridgingHeaderLookupTable(new SwiftLookupTable(nullptr)),
       platformAvailability(ctx.LangOpts), nameImporter(),
       DisableSourceImport(ctx.ClangImporterOpts.DisableSourceImport),
       DWARFImporter(dwarfImporterDelegate) {}

lib/Demangling/Demangler.cpp

@@ -91,9 +91,10 @@ static bool isRequirement(Node::Kind kind) {
 // Public utility functions    //
 //////////////////////////////////
 
-LLVM_NODISCARD void swift::Demangle::failAssert(const char *file, unsigned line,
-                                                NodePointer node,
-                                                const char *expr) {
+LLVM_ATTRIBUTE_NORETURN void swift::Demangle::failAssert(const char *file,
+                                                         unsigned line,
+                                                         NodePointer node,
+                                                         const char *expr) {
   fprintf(stderr, "%s:%u: assertion failed for Node %p: %s", file, line, node,
           expr);
   abort();

lib/Demangling/DemanglerAssert.h

@@ -51,8 +51,8 @@ namespace swift {
 namespace Demangle {
 SWIFT_BEGIN_INLINE_NAMESPACE
 
-LLVM_NODISCARD void failAssert(const char *file, unsigned line,
-                               NodePointer node, const char *expr);
+LLVM_ATTRIBUTE_NORETURN void failAssert(const char *file, unsigned line,
+                                        NodePointer node, const char *expr);
 
 SWIFT_END_INLINE_NAMESPACE
 } // end namespace Demangle