[AST/Sema] SE-0487: Remove @preEnumExtensibility attribute

Author: xedin

include/swift/AST/DeclAttr.def

@@ -888,11 +888,7 @@ SIMPLE_DECL_ATTR(concurrent, Concurrent,
   ABIBreakingToAdd | ABIBreakingToRemove | APIBreakingToAdd | APIBreakingToRemove | UnconstrainedInABIAttr,
   170)
 
-SIMPLE_DECL_ATTR(preEnumExtensibility, PreEnumExtensibility,
-  OnEnum,
-  ABIStableToAdd | ABIStableToRemove | APIStableToAdd | APIBreakingToRemove | UnconstrainedInABIAttr,
-  171)
-DECL_ATTR_FEATURE_REQUIREMENT(PreEnumExtensibility, NonexhaustiveAttribute)
+// Unused '171': Used to be `@preEnumExtensibility`
 
 DECL_ATTR(specialized, Specialized,
   OnConstructor | OnFunc | OnAccessor,

include/swift/AST/DiagnosticsSema.def

@@ -8811,9 +8811,6 @@ ERROR(nonexhaustive_attr_on_internal_type,none,
       "%select{private|fileprivate|internal|%error|%error|%error}1",
       (DeclName, AccessLevel))
 
-ERROR(pre_enum_extensibility_without_nonexhaustive,none,
-      "%0 can only be used together with '@nonexhaustive' attribute", (DeclAttribute))
-
 //===----------------------------------------------------------------------===//
 // MARK: `using` declaration
 //===----------------------------------------------------------------------===//

lib/AST/ASTDumper.cpp

@@ -5049,7 +5049,6 @@ class PrintAttribute : public AttributeVisitor<PrintAttribute, void, Label>,
   TRIVIAL_ATTR_PRINTER(WeakLinked, weak_linked)
   TRIVIAL_ATTR_PRINTER(Nonexhaustive, nonexhaustive)
   TRIVIAL_ATTR_PRINTER(Concurrent, concurrent)
-  TRIVIAL_ATTR_PRINTER(PreEnumExtensibility, preEnumExtensibility)
 
 #undef TRIVIAL_ATTR_PRINTER
 

lib/AST/ASTPrinter.cpp

@@ -3327,8 +3327,7 @@ suppressingFeatureAddressableTypes(PrintOptions &options,
 static void
 suppressingFeatureNonexhaustiveAttribute(PrintOptions &options,
                                          llvm::function_ref<void()> action) {
-  ExcludeAttrRAII scope1(options.ExcludeAttrList, DeclAttrKind::Nonexhaustive);
-  ExcludeAttrRAII scope2(options.ExcludeAttrList, DeclAttrKind::PreEnumExtensibility);
+  ExcludeAttrRAII scope(options.ExcludeAttrList, DeclAttrKind::Nonexhaustive);
   action();
 }
 

lib/ASTGen/Sources/ASTGen/DeclAttrs.swift

@@ -240,7 +240,6 @@ extension ASTGenVisitor {
         .EagerMove,
         .Exported,
         .Nonexhaustive,
-        .PreEnumExtensibility,
         .DiscardableResult,
         .DisfavoredOverload,
         .DynamicMemberLookup,

lib/Sema/TypeCheckAttr.cpp

@@ -248,14 +248,6 @@ class AttributeChecker : public AttributeVisitor<AttributeChecker> {
     }
   }
 
-  void visitPreEnumExtensibilityAttr(PreEnumExtensibilityAttr *attr) {
-    if (!D->getAttrs().hasAttribute<NonexhaustiveAttr>()) {
-      diagnoseAndRemoveAttr(
-          attr, diag::pre_enum_extensibility_without_nonexhaustive, attr);
-      return;
-    }
-  }
-
   void visitConcurrentAttr(ConcurrentAttr *attr) {
     checkExecutionBehaviorAttribute(attr);
 

lib/Sema/TypeCheckDeclOverride.cpp

@@ -1615,7 +1615,6 @@ namespace  {
     UNINTERESTING_ATTR(Optimize)
     UNINTERESTING_ATTR(Exclusivity)
     UNINTERESTING_ATTR(Nonexhaustive)
-    UNINTERESTING_ATTR(PreEnumExtensibility)
     UNINTERESTING_ATTR(NoLocks)
     UNINTERESTING_ATTR(NoAllocation)
     UNINTERESTING_ATTR(NoRuntime)