DiagnosticVerifier: Fix no-op range assignment in DiagnosticVerifier::handleDiagnostic

Author: AnthonyLatsis

include/swift/AST/DiagnosticConsumer.h

@@ -69,7 +69,9 @@ struct DiagnosticInfo {
   public:
     FixIt(CharSourceRange R, StringRef Str, ArrayRef<DiagnosticArgument> Args);
 
-    CharSourceRange getRange() const { return Range; }
+    CharSourceRange &getRange() { return Range; }
+    const CharSourceRange &getRange() const { return Range; }
+
     StringRef getText() const { return Text; }
   };
 

lib/Frontend/DiagnosticVerifier.cpp

@@ -970,8 +970,9 @@ void DiagnosticVerifier::handleDiagnostic(SourceManager &SM,
     for (auto &fixIt : capturedDiag.FixIts) {
       auto newStart = correctSM.getLocForForeignLoc(fixIt.getRange().getStart(),
                                                     SM);
-      fixIt.getRange() = CharSourceRange(newStart,
-                                         fixIt.getRange().getByteLength());
+      auto &mutableRange = fixIt.getRange();
+      mutableRange =
+          CharSourceRange(newStart, fixIt.getRange().getByteLength());
     }
   }
 }