Make a bunch of the EC stuff inlinable

Author: grynspan

Sources/Testing/Expectations/ExpectationContext.swift

@@ -163,8 +163,9 @@ extension __ExpectationContext {
   ///
   /// This function helps overloads of `callAsFunction(_:_:)` disambiguate
   /// themselves and avoid accidental recursion.
-  private mutating func _captureValue<T>(_ value: T, _ id: __ExpressionID) -> T {
-    self(value, id)
+  @usableFromInline mutating func captureValue<T>(_ value: T, _ id: __ExpressionID) -> T {
+    runtimeValues[id] = { Expression.Value(reflecting: value) }
+    return value
   }
 
   /// Capture information about a value for use if the expectation currently
@@ -179,9 +180,8 @@ extension __ExpectationContext {
   ///
   /// - Warning: This function is used to implement the `#expect()` and
   ///   `#require()` macros. Do not call it directly.
-  public mutating func callAsFunction<T>(_ value: T, _ id: __ExpressionID) -> T {
-    runtimeValues[id] = { Expression.Value(reflecting: value) }
-    return value
+  @inlinable public mutating func callAsFunction<T>(_ value: T, _ id: __ExpressionID) -> T {
+    captureValue(value, id)
   }
 
 #if SWT_SUPPORTS_MOVE_ONLY_EXPRESSION_EXPANSION
@@ -287,15 +287,15 @@ extension __ExpectationContext {
   ///
   /// - Warning: This function is used to implement the `#expect()` and
   ///   `#require()` macros. Do not call it directly.
-  public mutating func __cmp<T, U, R>(
+  @inlinable public mutating func __cmp<T, U, R>(
     _ op: (T, U) throws -> R,
     _ opID: __ExpressionID,
     _ lhs: T,
     _ lhsID: __ExpressionID,
     _ rhs: U,
     _ rhsID: __ExpressionID
   ) rethrows -> R {
-    try self(op(self(lhs, lhsID), self(rhs, rhsID)), opID)
+    try captureValue(op(captureValue(lhs, lhsID), captureValue(rhs, rhsID)), opID)
   }
 
   /// Compare two bidirectional collections using `==` or `!=`.
@@ -313,7 +313,7 @@ extension __ExpectationContext {
     _ rhs: C,
     _ rhsID: __ExpressionID
   ) -> Bool where C: BidirectionalCollection, C.Element: Equatable {
-    let result = self(op(self(lhs, lhsID), self(rhs, rhsID)), opID)
+    let result = captureValue(op(captureValue(lhs, lhsID), captureValue(rhs, rhsID)), opID)
 
     if !result {
       differences[opID] = { [lhs, rhs] in
@@ -332,15 +332,15 @@ extension __ExpectationContext {
   ///
   /// - Warning: This function is used to implement the `#expect()` and
   ///   `#require()` macros. Do not call it directly.
-  public mutating func __cmp<R>(
+  @inlinable public mutating func __cmp<R>(
     _ op: (R, R) -> Bool,
     _ opID: __ExpressionID,
     _ lhs: R,
     _ lhsID: __ExpressionID,
     _ rhs: R,
     _ rhsID: __ExpressionID
   ) -> Bool where R: RangeExpression & BidirectionalCollection, R.Element: Equatable {
-    self(op(self(lhs, lhsID), self(rhs, rhsID)), opID)
+    captureValue(op(captureValue(lhs, lhsID), captureValue(rhs, rhsID)), opID)
   }
 
   /// Compare two strings using `==` or `!=`.
@@ -359,7 +359,7 @@ extension __ExpectationContext {
     _ rhs: S,
     _ rhsID: __ExpressionID
   ) -> Bool where S: StringProtocol {
-    let result = self(op(self(lhs, lhsID), self(rhs, rhsID)), opID)
+    let result = captureValue(op(captureValue(lhs, lhsID), captureValue(rhs, rhsID)), opID)
 
     if !result {
       differences[opID] = { [lhs, rhs] in
@@ -409,12 +409,12 @@ extension __ExpectationContext {
   ///
   /// - Warning: This function is used to implement the `#expect()` and
   ///   `#require()` macros. Do not call it directly.
-  public mutating func __as<T, U>(_ value: T, _ valueID: __ExpressionID, _ type: U.Type, _ typeID: __ExpressionID) -> U? {
-    let result = self(value, valueID) as? U
+  @inlinable public mutating func __as<T, U>(_ value: T, _ valueID: __ExpressionID, _ type: U.Type, _ typeID: __ExpressionID) -> U? {
+    let result = captureValue(value, valueID) as? U
 
     if result == nil {
       let correctType = Swift.type(of: value as Any)
-      _ = self(correctType, typeID)
+      _ = captureValue(correctType, typeID)
     }
 
     return result
@@ -438,12 +438,12 @@ extension __ExpectationContext {
   ///
   /// - Warning: This function is used to implement the `#expect()` and
   ///   `#require()` macros. Do not call it directly.
-  public mutating func __is<T, U>(_ value: T, _ valueID: __ExpressionID, _ type: U.Type, _ typeID: __ExpressionID) -> Bool {
-    let result = self(value, valueID) is U
+  @inlinable public mutating func __is<T, U>(_ value: T, _ valueID: __ExpressionID, _ type: U.Type, _ typeID: __ExpressionID) -> Bool {
+    let result = captureValue(value, valueID) is U
 
     if !result {
       let correctType = Swift.type(of: value as Any)
-      _ = self(correctType, typeID)
+      _ = captureValue(correctType, typeID)
     }
 
     return result
@@ -468,8 +468,8 @@ extension __ExpectationContext {
   ///
   /// - Warning: This function is used to implement the `#expect()` and
   ///   `#require()` macros. Do not call it directly.
-  public mutating func callAsFunction<P1, P2>(_ value: P1?, _ id: __ExpressionID) -> P2! where P1: _Pointer, P2: _Pointer {
-    _captureValue(value, id).flatMap { value in
+  @inlinable public mutating func callAsFunction<P1, P2>(_ value: P1?, _ id: __ExpressionID) -> P2! where P1: _Pointer, P2: _Pointer {
+    captureValue(value, id).flatMap { value in
       P2(bitPattern: Int(bitPattern: value))
     }
   }
@@ -493,8 +493,8 @@ extension __ExpectationContext {
   ///
   /// - Warning: This function is used to implement the `#expect()` and
   ///   `#require()` macros. Do not call it directly.
-  public mutating func callAsFunction(_ value: String, _ id: __ExpressionID) -> String {
-    _captureValue(value, id)
+  @inlinable public mutating func callAsFunction(_ value: String, _ id: __ExpressionID) -> String {
+    captureValue(value, id)
   }
 
   /// Capture information about a value for use if the expectation currently
@@ -512,8 +512,8 @@ extension __ExpectationContext {
   ///
   /// - Warning: This function is used to implement the `#expect()` and
   ///   `#require()` macros. Do not call it directly.
-  public mutating func callAsFunction(_ value: String, _ id: __ExpressionID) -> String? {
-    _captureValue(value, id)
+  @inlinable public mutating func callAsFunction(_ value: String, _ id: __ExpressionID) -> String? {
+    captureValue(value, id)
   }
 
   /// Capture information about a value for use if the expectation currently
@@ -531,7 +531,7 @@ extension __ExpectationContext {
   ///
   /// - Warning: This function is used to implement the `#expect()` and
   ///   `#require()` macros. Do not call it directly.
-  public mutating func callAsFunction(_ value: String?, _ id: __ExpressionID) -> String? {
-    _captureValue(value, id)
+  @inlinable public mutating func callAsFunction(_ value: String?, _ id: __ExpressionID) -> String? {
+    captureValue(value, id)
   }
 }