Remove experimental spi from issue severity (#1247)

Remove experimental spi from issue severity

### Motivation:

The Issue Severity proposal was approved.


https://github.com/swiftlang/swift-evolution/blob/main/proposals/testing/0013-issue-severity-warning.md

### Modifications:

Removed experimental spi from issue severity and updated comments.

### Checklist:

- [x] Code and documentation should follow the style of the [Style
Guide](https://github.com/apple/swift-testing/blob/main/Documentation/StyleGuide.md).
- [x] If public symbols are renamed or modified, DocC references should
be updated.

Author: suzannaratcliff

Sources/Testing/Issues/Issue+Recording.swift

@@ -50,7 +50,7 @@ extension Issue {
     return self
   }
 
-  /// Record an issue when a running test fails unexpectedly.
+  /// Records an issue that a test encounters while it's running.
   ///
   /// - Parameters:
   ///   - comment: A comment describing the expectation.
@@ -62,18 +62,23 @@ extension Issue {
   /// Use this function if, while running a test, an issue occurs that cannot be
   /// represented as an expectation (using the ``expect(_:_:sourceLocation:)``
   /// or ``require(_:_:sourceLocation:)-5l63q`` macros.)
+  @_disfavoredOverload
+  @_documentation(visibility: private)
+  @available(*, deprecated, message: "Use record(_:severity:sourceLocation:) instead.")
   @discardableResult public static func record(
     _ comment: Comment? = nil,
     sourceLocation: SourceLocation = #_sourceLocation
   ) -> Self {
     record(comment, severity: .error, sourceLocation: sourceLocation)
   }
 
-  /// Record an issue when a running test fails unexpectedly.
+  /// Records an issue that a test encounters while it's running.
   ///
   /// - Parameters:
   ///   - comment: A comment describing the expectation.
-  ///   - severity: The severity of the issue.
+  ///   - severity: The severity level of the issue.  The testing library marks the
+  ///   test as failed if the severity is greater than ``Issue/Severity/warning``.
+  ///   The default is ``Issue/Severity/error``.
   ///   - sourceLocation: The source location to which the issue should be
   ///     attributed.
   ///
@@ -82,10 +87,13 @@ extension Issue {
   /// Use this function if, while running a test, an issue occurs that cannot be
   /// represented as an expectation (using the ``expect(_:_:sourceLocation:)``
   /// or ``require(_:_:sourceLocation:)-5l63q`` macros.)
-  @_spi(Experimental)
+  /// 
+  /// @Metadata {
+  ///   @Available(Swift, introduced: 6.3)
+  /// }
   @discardableResult public static func record(
     _ comment: Comment? = nil,
-    severity: Severity,
+    severity: Severity = .error,
     sourceLocation: SourceLocation = #_sourceLocation
   ) -> Self {
     let sourceContext = SourceContext(backtrace: .current(), sourceLocation: sourceLocation)

Sources/Testing/Issues/Issue.swift

@@ -84,7 +84,10 @@ public struct Issue: Sendable {
   ///
   /// - ``warning``
   /// - ``error``
-  @_spi(Experimental)
+  ///
+  /// @Metadata {
+  ///   @Available(Swift, introduced: 6.3)
+  /// }
   public enum Severity: Sendable {
     /// The severity level for an issue which should be noted but is not
     /// necessarily an error.
@@ -101,7 +104,10 @@ public struct Issue: Sendable {
   }
 
   /// The severity of this issue.
-  @_spi(Experimental)
+  ///
+  /// @Metadata {
+  ///   @Available(Swift, introduced: 6.3)
+  /// }
   public var severity: Severity
 
   /// Whether or not this issue should cause the test it's associated with to be
@@ -114,7 +120,10 @@ public struct Issue: Sendable {
   ///
   /// Use this property to determine if an issue should be considered a failure, instead of
   /// directly comparing the value of the ``severity`` property.
-  @_spi(Experimental)
+  ///
+  /// @Metadata {
+  ///   @Available(Swift, introduced: 6.3)
+  /// }
   public var isFailure: Bool {
     return !self.isKnown && self.severity >= .error
   }
@@ -324,7 +333,10 @@ extension Issue {
     public var kind: Kind.Snapshot
 
     /// The severity of this issue.
-    @_spi(Experimental)
+    /// 
+    /// @Metadata {
+    ///   @Available(Swift, introduced: 6.3)
+    /// }
     public var severity: Severity
 
     /// Any comments provided by the developer and associated with this issue.

Sources/Testing/Running/Configuration.swift

@@ -184,13 +184,7 @@ public struct Configuration: Sendable {
     /// Whether or not events of the kind ``Event/Kind-swift.enum/issueRecorded(_:)``
     /// containing issues with warning (or lower) severity should be delivered
     /// to the event handler of the configuration these options are applied to.
-    ///
-    /// By default, events matching this criteria are not delivered to event
-    /// handlers since this is an experimental feature.
-    ///
-    /// - Warning: Warning issues are not yet an approved feature.
-    @_spi(Experimental)
-    public var isWarningIssueRecordedEventEnabled: Bool = false
+    public var isWarningIssueRecordedEventEnabled: Bool = true
 
     /// Whether or not events of the kind
     /// ``Event/Kind-swift.enum/expectationChecked(_:)`` should be delivered to