Polling confirmations: Handle extremely large polling iterations

Author: younata

Sources/Testing/Polling/Polling.swift

@@ -384,7 +384,11 @@ private struct Poller {
     precondition(interval > Duration.zero)
     precondition(duration > interval)
 
-    let iterations = max(Int(duration.seconds() / interval.seconds()), 1)
+    let iterations = Int(exactly:
+        max(duration.seconds() / interval.seconds(), 1).rounded()
+    ) ?? Int.max
+    // if Int(exactly:) returns nil, then that generally means the value is too
+    // large. In which case, we should fall back to Int.max.
 
     let failureReason: PollingFailureReason
     switch await poll(iterations: iterations, expression: body) {

Tests/TestingTests/PollingTests.swift

@@ -210,6 +210,18 @@ struct PollingConfirmationTests {
           ) { true }
         }
       }
+
+      @available(_clockAPI, *)
+      @Test("Handles extremely large polling iterations")
+      func handlesLargePollingIterations() async throws {
+        await #expect(processExitsWith: .success) {
+          try await confirmation(
+            until: .firstPass,
+            within: .seconds(Int.max),
+            pollingEvery: .nanoseconds(1)
+          ) { true }
+        }
+      }
 #endif
     }
   }