Add test to verify borrow (msg) is a function call

Author: meg-gupta

CodeGeneration/Tests/ValidateSyntaxNodes/ValidateSyntaxNodes.swift

@@ -317,12 +317,6 @@ class ValidateSyntaxNodes: XCTestCase {
         ),
 
         // MARK: Tokens that contain underscores
-        ValidationFailure(
-          node: .borrowExpr,
-          message:
-            "child 'borrowKeyword' has a single keyword as its only token choice and should thus be named '_borrowKeyword'"
-            // _borrow is underscored and thus BorrowKeyword is the correct spelling
-        ),
         ValidationFailure(
           node: .conventionWitnessMethodAttributeArguments,
           message:
@@ -410,7 +404,11 @@ class ValidateSyntaxNodes: XCTestCase {
           message: "child 'consumeKeyword' only has keywords as its token choices and should thus end with 'Specifier'"
             // ConsumeKeyword can be 'consume' or '_move' and '_move' is deprecated
         ),
-
+        ValidationFailure(
+          node: .borrowExpr,
+          message: "child 'borrowKeyword' only has keywords as its token choices and should thus end with 'Specifier'"
+            // BorrowKeyword can be 'borrow' or '_borrow', eventually '_borrow' will be deprecated
+        ),
         // MARK: Conceptually a value, not a specifier
         ValidationFailure(
           node: .booleanLiteralExpr,

Tests/SwiftParserTest/ExpressionTests.swift

@@ -1210,6 +1210,38 @@ final class ExpressionTests: ParserTestCase {
     assertParse("use(_borrow msg)")
     assertParse("_borrow msg")
     assertParse("let b = (_borrow self).buffer")
+    assertParse("borrow msg")
+    assertParse("use(borrow msg)")
+    assertParse("borrow(msg)")
+    assertParse("borrow (msg)")
+  }
+
+  func testBorrowNameFunctionCallStructure1() {
+    assertParse(
+      """
+      borrow(msg)
+      """,
+      substructure: FunctionCallExprSyntax(
+        calledExpression: DeclReferenceExprSyntax(baseName: .identifier("borrow")),
+        leftParen: .leftParenToken(),
+        arguments: LabeledExprListSyntax([LabeledExprSyntax(expression: ExprSyntax("msg"))]),
+        rightParen: .rightParenToken()
+      )
+    )
+  }
+
+  func testBorrowNameFunctionCallStructure2() {
+    assertParse(
+      """
+      borrow (msg)
+      """,
+      substructure: FunctionCallExprSyntax(
+        calledExpression: DeclReferenceExprSyntax(baseName: .identifier("borrow")),
+        leftParen: .leftParenToken(),
+        arguments: LabeledExprListSyntax([LabeledExprSyntax(expression: ExprSyntax("msg"))]),
+        rightParen: .rightParenToken()
+      )
+    )
   }
 
   func testCodeCompletionExpressions() {