[SwiftRefactor] PackageManifest: Change source control dependency to always accept a string

This matches `PackageDescription` which explicitly states that
all source control dependencies expect a URL.

Author: xedin

Sources/SwiftRefactor/PackageManifest/AddPackageTarget.swift

@@ -350,7 +350,7 @@ fileprivate extension PackageDependency {
     return .sourceControl(
       .init(
         identity: "swift-syntax",
-        location: .remote(swiftSyntaxURL),
+        location: swiftSyntaxURL,
         requirement: .rangeFrom(version)
       )
     )

Sources/SwiftRefactor/PackageManifest/PackageDependency.swift

@@ -29,10 +29,10 @@ public enum PackageDependency: Sendable {
 
   public struct SourceControl: Sendable {
     public let identity: String
-    public let location: Location
+    public let location: String
     public let requirement: Requirement
 
-    public init(identity: String, location: Location, requirement: Requirement) {
+    public init(identity: String, location: String, requirement: Requirement) {
       self.identity = identity
       self.location = location
       self.requirement = requirement
@@ -45,11 +45,6 @@ public enum PackageDependency: Sendable {
       case revision(String)
       case branch(String)
     }
-
-    public enum Location: Sendable {
-      case local(String)
-      case remote(String)
-    }
   }
 
   public struct Registry: Sendable {
@@ -85,12 +80,7 @@ extension PackageDependency.SourceControl: ManifestSyntaxRepresentable {
   func asSyntax() -> ExprSyntax {
     // TODO: Not handling identity, nameForTargetDependencyResolutionOnly,
     // or productFilter yet.
-    switch location {
-    case .local:
-      fatalError()
-    case .remote(let url):
-      return ".package(url: \(literal: url.description), \(requirement.asSyntax()))"
-    }
+    ".package(url: \(literal: location.description), \(requirement.asSyntax()))"
   }
 }
 

Tests/SwiftRefactorTest/ManifestEditTests.swift

@@ -24,7 +24,7 @@ final class ManifestEditTests: XCTestCase {
   static let swiftSystemPackageDependency: PackageDependency = .sourceControl(
     .init(
       identity: "swift-system",
-      location: .remote(swiftSystemURL),
+      location: swiftSystemURL,
       requirement: .branch("main")
     )
   )
@@ -55,7 +55,7 @@ final class ManifestEditTests: XCTestCase {
         dependency: .sourceControl(
           .init(
             identity: "swift-system",
-            location: .remote(Self.swiftSystemURL),
+            location: Self.swiftSystemURL,
             requirement: .branch("main")
           )
         )
@@ -89,7 +89,7 @@ final class ManifestEditTests: XCTestCase {
         dependency: .sourceControl(
           .init(
             identity: "swift-system",
-            location: .remote(Self.swiftSystemURL),
+            location: Self.swiftSystemURL,
             requirement: .exact("510.0.0")
           )
         )
@@ -121,7 +121,7 @@ final class ManifestEditTests: XCTestCase {
         dependency: .sourceControl(
           .init(
             identity: "swift-system",
-            location: .remote(Self.swiftSystemURL),
+            location: Self.swiftSystemURL,
             requirement: .exact("510.0.0")
           )
         )
@@ -155,7 +155,7 @@ final class ManifestEditTests: XCTestCase {
         dependency: .sourceControl(
           .init(
             identity: "swift-system",
-            location: .remote(Self.swiftSystemURL),
+            location: Self.swiftSystemURL,
             requirement: .exact("510.0.0")
           )
         )
@@ -213,7 +213,7 @@ final class ManifestEditTests: XCTestCase {
         dependency: .sourceControl(
           .init(
             identity: "swift-system",
-            location: .remote(Self.swiftSystemURL),
+            location: Self.swiftSystemURL,
             requirement: .rangeFrom("510.0.0")
           )
         )
@@ -242,7 +242,7 @@ final class ManifestEditTests: XCTestCase {
         dependency: .sourceControl(
           .init(
             identity: "swift-system",
-            location: .remote(Self.swiftSystemURL),
+            location: Self.swiftSystemURL,
             requirement: .rangeFrom("510.0.0")
           )
         )
@@ -269,7 +269,7 @@ final class ManifestEditTests: XCTestCase {
         dependency: .sourceControl(
           .init(
             identity: "swift-system",
-            location: .remote(Self.swiftSystemURL),
+            location: Self.swiftSystemURL,
             requirement: .rangeFrom("510.0.0")
           )
         )
@@ -300,7 +300,7 @@ final class ManifestEditTests: XCTestCase {
         dependency: .sourceControl(
           .init(
             identity: "swift-system",
-            location: .remote(Self.swiftSystemURL),
+            location: Self.swiftSystemURL,
             requirement: .range(lowerBound: "508.0.0", upperBound: "510.0.0")
           )
         )