[SwiftRefactor] PackageManifest: Replace SemanticVersion with a String

This removes final stub type that could simply be a string and instead
of hard-coding a version of swift-syntax library for new dependencies,
let's use a placeholder.

Author: xedin

Sources/SwiftRefactor/CMakeLists.txt

@@ -35,7 +35,6 @@ add_swift_syntax_library(SwiftRefactor
   PackageManifest/PackageEdit.swift
   PackageManifest/PackageTarget.swift
   PackageManifest/ProductDescription.swift
-  PackageManifest/SemanticVersion.swift
   PackageManifest/StringUtils.swift
   PackageManifest/SyntaxEditUtils.swift
 )

Sources/SwiftRefactor/PackageManifest/AddPackageTarget.swift

@@ -50,7 +50,7 @@ public struct AddPackageTarget: ManifestEditRefactoringProvider {
     case swiftTesting = "swift-testing"
 
     /// The default testing library to use.
-    public static let `default`: TestHarness = .xctest
+    public static let `default`: TestHarness = .swiftTesting
   }
 
   /// Additional configuration information to guide the package editing
@@ -59,17 +59,10 @@ public struct AddPackageTarget: ManifestEditRefactoringProvider {
     /// The test harness to use.
     public var testHarness: TestHarness
 
-    public let swiftSyntaxVersion: SemanticVersion
-    public let swiftTestingVersion: SemanticVersion
-
     public init(
-      testHarness: TestHarness = .default,
-      swiftSyntaxVersion: SemanticVersion = SemanticVersion("600.0.0-latest"),
-      swiftTestingVersion: SemanticVersion = SemanticVersion("0.8.0")
+      testHarness: TestHarness = .default
     ) {
       self.testHarness = testHarness
-      self.swiftSyntaxVersion = swiftSyntaxVersion
-      self.swiftTestingVersion = swiftTestingVersion
     }
   }
 
@@ -148,9 +141,7 @@ public struct AddPackageTarget: ManifestEditRefactoringProvider {
         newPackageCall =
           try AddPackageDependency
           .addPackageDependencyLocal(
-            .swiftSyntax(
-              version: configuration.swiftSyntaxVersion
-            ),
+            .swiftSyntax(from: "<#version#>"),
             to: newPackageCall
           )
 
@@ -357,10 +348,8 @@ fileprivate extension PackageDependency {
     "https://github.com/swiftlang/swift-syntax.git"
   }
 
-  /// Package dependency on the swift-syntax package.
-  static func swiftSyntax(
-    version: SemanticVersion
-  ) -> PackageDependency {
+  /// Package dependency on the swift-syntax package starting from a partial version.
+  static func swiftSyntax(from version: String) -> PackageDependency {
     return .sourceControl(
       .init(
         identity: "swift-syntax",

Sources/SwiftRefactor/PackageManifest/PackageDependency.swift

@@ -39,9 +39,9 @@ public enum PackageDependency: Sendable {
     }
 
     public enum Requirement: Sendable {
-      case exact(SemanticVersion)
-      case rangeFrom(SemanticVersion)
-      case range(lowerBound: SemanticVersion, upperBound: SemanticVersion)
+      case exact(String)
+      case rangeFrom(String)
+      case range(lowerBound: String, upperBound: String)
       case revision(String)
       case branch(String)
     }
@@ -58,9 +58,9 @@ public enum PackageDependency: Sendable {
 
     /// The dependency requirement.
     public enum Requirement: Sendable {
-      case exact(SemanticVersion)
-      case rangeFrom(SemanticVersion)
-      case range(lowerBound: SemanticVersion, upperBound: SemanticVersion)
+      case exact(String)
+      case rangeFrom(String)
+      case range(lowerBound: String, upperBound: String)
     }
   }
 }

Sources/SwiftRefactor/PackageManifest/SemanticVersion.swift

@@ -90,7 +90,7 @@ final class ManifestEditTests: XCTestCase {
           .init(
             identity: "swift-system",
             location: .remote(Self.swiftSystemURL),
-            requirement: .exact(SemanticVersion("510.0.0"))
+            requirement: .exact("510.0.0")
           )
         )
       )
@@ -122,7 +122,7 @@ final class ManifestEditTests: XCTestCase {
           .init(
             identity: "swift-system",
             location: .remote(Self.swiftSystemURL),
-            requirement: .exact(SemanticVersion("510.0.0"))
+            requirement: .exact("510.0.0")
           )
         )
       )
@@ -156,7 +156,7 @@ final class ManifestEditTests: XCTestCase {
           .init(
             identity: "swift-system",
             location: .remote(Self.swiftSystemURL),
-            requirement: .exact(SemanticVersion("510.0.0"))
+            requirement: .exact("510.0.0")
           )
         )
       )
@@ -190,7 +190,7 @@ final class ManifestEditTests: XCTestCase {
           .init(
             identity: "swift-system",
             location: .remote(Self.swiftSystemURL),
-            requirement: .rangeFrom(SemanticVersion("510.0.0"))
+            requirement: .rangeFrom("510.0.0")
           )
         )
       )
@@ -219,7 +219,7 @@ final class ManifestEditTests: XCTestCase {
           .init(
             identity: "swift-system",
             location: .remote(Self.swiftSystemURL),
-            requirement: .rangeFrom(SemanticVersion("510.0.0"))
+            requirement: .rangeFrom("510.0.0")
           )
         )
       )
@@ -246,7 +246,7 @@ final class ManifestEditTests: XCTestCase {
           .init(
             identity: "swift-system",
             location: .remote(Self.swiftSystemURL),
-            requirement: .rangeFrom(SemanticVersion("510.0.0"))
+            requirement: .rangeFrom("510.0.0")
           )
         )
       )
@@ -277,7 +277,7 @@ final class ManifestEditTests: XCTestCase {
           .init(
             identity: "swift-system",
             location: .remote(Self.swiftSystemURL),
-            requirement: .range(lowerBound: SemanticVersion("508.0.0"), upperBound: SemanticVersion("510.0.0"))
+            requirement: .range(lowerBound: "508.0.0", upperBound: "510.0.0")
           )
         )
       )
@@ -562,7 +562,7 @@ final class ManifestEditTests: XCTestCase {
         let package = Package(
             name: "packages",
             dependencies: [
-                .package(url: "https://github.com/swiftlang/swift-syntax.git", from: "600.0.0-latest"),
+                .package(url: "https://github.com/swiftlang/swift-syntax.git", from: "<#version#>"),
             ],
             targets: [
                 .macro(