Revert attribute changes

Author: calda

Sources/SwiftParser/Attributes.swift

@@ -362,7 +362,7 @@ extension Parser {
     let additionalArgs = self.parseArgumentListElements(
       pattern: .none,
       flavor: .attributeArguments,
-      allowTrailingComma: true
+      allowTrailingComma: false
     )
     return [roleElement] + additionalArgs
   }
@@ -852,11 +852,6 @@ extension Parser {
           arena: self.arena
         )
       )
-
-      // If this was a trailing closure then there are no more elements
-      if self.at(.rightParen) {
-        break
-      }
     } while keepGoing != nil
     return RawBackDeployedAttributeArgumentsSyntax(
       unexpectedBeforeLabel,
@@ -888,11 +883,6 @@ extension Parser {
           arena: self.arena
         )
       )
-
-      // If this was a trailing closure then there are no more elements
-      if self.at(.rightParen) {
-        break
-      }
     } while keepGoing != nil
 
     return RawOriginallyDefinedInAttributeArgumentsSyntax(
@@ -1011,11 +1001,6 @@ extension Parser {
           arena: self.arena
         )
       )
-
-      // If this was a trailing closure then there are no more elements
-      if self.at(.rightParen) {
-        break
-      }
     } while keepGoing != nil
 
     return RawDocumentationAttributeArgumentListSyntax(elements: arguments, arena: self.arena)

Sources/SwiftParser/Availability.swift

@@ -47,11 +47,6 @@ extension Parser {
             arena: self.arena
           )
         )
-
-        // If this was a trailing closure, there are no more elements
-        if self.at(.rightParen) {
-          break
-        }
       } while keepGoing != nil
         && self.hasProgressed(&availabilityArgumentProgress)
     }

Tests/SwiftParserTest/AttributeTests.swift

@@ -470,31 +470,13 @@ final class AttributeTests: ParserTestCase {
       """
     )
 
-    assertParse(
-      """
-      @backDeployed(
-        before: macOS 12.0,
-      )
-      struct Foo {}
-      """
-    )
-
     assertParse(
       """
       @backDeployed(before: macos 12.0, iOS 15.0)
       struct Foo {}
       """
     )
 
-    assertParse(
-      """
-      @backDeployed(
-        before: macos 12.0, 
-        iOS 15.0,)
-      struct Foo {}
-      """
-    )
-
     assertParse(
       """
       @available(macOS 11.0, *)
@@ -555,16 +537,6 @@ final class AttributeTests: ParserTestCase {
       """
     )
 
-    assertParse(
-      """
-      @_originallyDefinedIn(
-        module: "ToasterKit",
-        macOS 10.15,
-      )
-      struct Vehicle {}
-      """
-    )
-
     assertParse(
       """
       @_originallyDefinedIn(module: "ToasterKit", macOS 10.15, iOS 13)
@@ -874,26 +846,6 @@ final class AttributeTests: ParserTestCase {
         }
         """
     )
-
-    assertParse(
-      """
-      @attached(
-        member,
-        names: named(deinit),
-      )
-      macro m()
-      """
-    )
-
-    assertParse(
-      """
-      @attached(
-        extension,
-        conformances: P1, P2,
-      )
-      macro AddAllConformances()
-      """
-    )
   }
 
   func testAttachedExtensionAttribute() {

Tests/SwiftParserTest/translated/AvailabilityQueryTests.swift

@@ -400,7 +400,17 @@ final class AvailabilityQueryTests: ParserTestCase {
       """
       if #available(OSX 10.51,1️⃣) {
       }
-      """
+      """,
+      diagnostics: [
+        DiagnosticSpec(
+          message: "expected version restriction in availability argument",
+          fixIts: ["insert version restriction"]
+        )
+      ],
+      fixedSource: """
+        if #available(OSX 10.51, <#identifier#>) {
+        }
+        """
     )
   }
 

Tests/SwiftParserTest/translated/AvailabilityQueryUnavailabilityTests.swift

@@ -381,9 +381,19 @@ final class AvailabilityQueryUnavailabilityTests: ParserTestCase {
   func testAvailabilityQueryUnavailability23() {
     assertParse(
       """
-      if #unavailable(OSX 10.51,) {
+      if #unavailable(OSX 10.51,1️⃣) {
       }
-      """
+      """,
+      diagnostics: [
+        DiagnosticSpec(
+          message: "expected version restriction in availability argument",
+          fixIts: ["insert version restriction"]
+        )
+      ],
+      fixedSource: """
+        if #unavailable(OSX 10.51, <#identifier#>) {
+        }
+        """
     )
   }
 
@@ -601,18 +611,4 @@ final class AvailabilityQueryUnavailabilityTests: ParserTestCase {
       ]
     )
   }
-
-  func testTrailingComma() {
-    assertParse(
-      """
-      func fooDeprecated() {
-        if #available(
-          iOS 18.0,
-          macOS 14.0,
-          *,
-        ) {}
-      }
-      """
-    )
-  }
 }