Merge pull request #3187 from artemcm/FixRangePrecondition

artemcm · web-flow · commit 44ece85abda9 · 2025-11-13T18:40:55.000-05:00
[NFC] Avoid use of unavailable range 'contains' method
diff --git a/Sources/SwiftWarningControl/WarningControlRegions.swift b/Sources/SwiftWarningControl/WarningControlRegions.swift
@@ -254,7 +254,7 @@ private class WarningControlRegionNode {
 
   /// Add a child region that is directly nested within this region
   func addChild(_ node: WarningControlRegionNode) {
-    precondition(range.contains(node.range))
+    precondition(range.lowerBound <= node.range.lowerBound && node.range.upperBound <= range.upperBound)
     children.append(node)
     children.sort()
   }
diff --git a/Tests/SwiftWarningControlTest/WarningControlTests.swift b/Tests/SwiftWarningControlTest/WarningControlTests.swift
@@ -386,8 +386,6 @@ private func assertWarningGroupControl(
       groupInheritanceTree: groupInheritanceTree
     )
 
-    print(warningControlRegions.debugDescription)
-
     let groupControl = token.warningGroupControl(
       for: diagnosticGroupID,
       globalControls: globalControls,

Original file line number	Diff line number	Diff line change
`@@ -254,7 +254,7 @@ private class WarningControlRegionNode {`
`254`	`254`
`255`	`255`	`/// Add a child region that is directly nested within this region`
`256`	`256`	`func addChild(_ node: WarningControlRegionNode) {`
`257`		`- precondition(range.contains(node.range))`
	`257`	`+ precondition(range.lowerBound <= node.range.lowerBound && node.range.upperBound <= range.upperBound)`
`258`	`258`	`children.append(node)`
`259`	`259`	`children.sort()`
`260`	`260`	`}`
Original file line number	Diff line number	Diff line change
`@@ -386,8 +386,6 @@ private func assertWarningGroupControl(`
`386`	`386`	`groupInheritanceTree: groupInheritanceTree`
`387`	`387`	`)`
`388`	`388`
`389`		`- print(warningControlRegions.debugDescription)`
`390`		`-`
`391`	`389`	`let groupControl = token.warningGroupControl(`
`392`	`390`	`for: diagnosticGroupID,`
`393`	`391`	`globalControls: globalControls,`